Enabling reconnection by default and Database.isConnected() properly pings the server to check status of connection

Author: mariano

CHANGELOG

@@ -2,6 +2,11 @@ For more in depth changelog, check the Github Commits:
 
 https://github.com/mariano/node-db-mysql/commits/master
 
+0.6.2
+-----
+* Reconnection is enabled by default
+* Database.isConnected() properly pings the server to check status of connection
+
 0.6.1
 -----
 * Fixing issue where Query.execute(callback, options) was not easily doable

lib/node-db

@@ -2,7 +2,7 @@
 , "description" : "MySQL database bindings for Node.JS"
 , "keywords": ["database","db","native","binding","library","plugin","client","mysql","libmysql"]
 , "homepage" : "http://nodejsdb.org/db-mysql"
-, "version" : "0.6.1"
+, "version" : "0.6.2"
 , "engines" : { "node" : ">=0.4.1" }
 , "maintainers" :
   [ { "name": "Mariano Iglesias"

package.json

@@ -4,7 +4,7 @@
 node_db_mysql::Connection::Connection()
     : compress(false),
       readTimeout(0),
-      reconnect(false),
+      reconnect(true),
       sslVerifyServer(false),
       timeout(0),
       writeTimeout(0),
@@ -51,6 +51,13 @@ void node_db_mysql::Connection::setWriteTimeout(const uint32_t writeTimeout) thr
     this->writeTimeout = writeTimeout;
 }
 
+bool node_db_mysql::Connection::isAlive(bool ping) throw() {
+    if (ping && this->alive) {
+        this->alive = (mysql_ping(this->connection) == 0);
+    }
+    return this->alive;
+}
+
 void node_db_mysql::Connection::open() throw(node_db::Exception&) {
     this->close();
 
@@ -84,7 +91,7 @@ void node_db_mysql::Connection::open() throw(node_db::Exception&) {
         mysql_options(this->connection, MYSQL_OPT_WRITE_TIMEOUT, (const char*) &this->writeTimeout);
     }
 
-    this->opened = mysql_real_connect(
+    this->alive = mysql_real_connect(
         this->connection,
         this->hostname.c_str(),
         this->user.c_str(),
@@ -99,16 +106,16 @@ void node_db_mysql::Connection::open() throw(node_db::Exception&) {
     mysql_options(this->connection, MYSQL_OPT_RECONNECT, (const char*) &this->reconnect);
 #endif
 
-    if (!this->opened) {
+    if (!this->alive) {
         throw node_db::Exception(mysql_error(this->connection));
     }
 }
 
 void node_db_mysql::Connection::close() {
-    if (this->opened) {
+    if (this->alive) {
         mysql_close(this->connection);
     }
-    this->opened = false;
+    this->alive = false;
 }
 
 std::string node_db_mysql::Connection::escape(const std::string& string) const throw(node_db::Exception&) {
@@ -125,10 +132,7 @@ std::string node_db_mysql::Connection::escape(const std::string& string) const t
 }
 
 std::string node_db_mysql::Connection::version() const {
-    std::string version;
-    if (this->opened) {
-        version = mysql_get_server_info(this->connection);
-    }
+    std::string version = mysql_get_server_info(this->connection);
     return version;
 }
 
@@ -137,10 +141,6 @@ node_db::Result* node_db_mysql::Connection::query(const std::string& query) cons
     throw node_db::Exception("This binding needs to be linked with the thread safe MySQL library libmysqlclient_r");
 #endif
 
-    if (!this->opened) {
-        throw node_db::Exception("Can't execute query without an opened connection");
-    }
-
     if (mysql_real_query(this->connection, query.c_str(), query.length()) != 0) {
         throw node_db::Exception(mysql_error(this->connection));
     }

src/connection.cc

@@ -21,6 +21,7 @@ class Connection : public node_db::Connection {
         void setSslVerifyServer(const bool sslVerifyServer) throw();
         void setTimeout(const uint32_t timeout) throw();
         void setWriteTimeout(const uint32_t writeTimeout) throw();
+        bool isAlive(bool ping) throw();
         void open() throw(node_db::Exception&);
         void close();
         std::string escape(const std::string& string) const throw(node_db::Exception&);

src/connection.h

@@ -11,7 +11,7 @@ from os.path import exists
 
 srcdir = "."
 blddir = "build"
-VERSION = "0.6.1"
+VERSION = "0.6.2"
 
 def set_options(opt):
   opt.tool_options("compiler_cxx")