asan

Author: BrennanConroy

CMakeSettings.json

@@ -10,8 +10,7 @@
       "cmakeCommandArgs": "-DBUILD_SAMPLES=true -DUSE_CPPRESTSDK=true",
       "buildCommandArgs": "-v",
       "ctestCommandArgs": "",
-      "cmakeToolchain": "${projectDir}\\submodules\\vcpkg\\scripts\\buildsystems\\vcpkg.cmake",
-      "variables": []
+      "cmakeToolchain": "${projectDir}\\submodules\\vcpkg\\scripts\\buildsystems\\vcpkg.cmake"
     },
     {
       "name": "x64-Release",
@@ -23,8 +22,20 @@
       "buildCommandArgs": "-v",
       "ctestCommandArgs": "",
       "cmakeToolchain": "${projectDir}\\submodules\\vcpkg\\scripts\\buildsystems\\vcpkg.cmake",
-      "inheritEnvironments": [ "msvc_x64_x64" ],
-      "variables": []
+      "inheritEnvironments": [ "msvc_x64_x64" ]
+    },
+    {
+      "name": "x64-Release-AddressSanitizer",
+      "generator": "Ninja",
+      "configurationType": "RelWithDebInfo",
+      "buildRoot": "${projectDir}\\out\\build\\${name}",
+      "installRoot": "${projectDir}\\out\\install\\${name}",
+      "cmakeCommandArgs": "-DBUILD_SAMPLES=true -DUSE_CPPRESTSDK=false",
+      "buildCommandArgs": "-v",
+      "ctestCommandArgs": "",
+      "addressSanitizerEnabled": true,
+      "cmakeToolchain": "${projectDir}\\submodules\\vcpkg\\scripts\\buildsystems\\vcpkg.cmake",
+      "inheritEnvironments": [ "msvc_x64_x64" ]
     }
   ]
 }

azure-pipelines.yml

@@ -90,7 +90,7 @@ stages:
       agentOs: Windows
       jobName: Windows_Build_Test
       useCppRestSDK: false
-      cMakeRunArgs: '-A x64'
+      cMakeRunArgs: '-A x64 -E env CXXFLAGS="/fsanitize=address"'
 
   - template: .azure/default-build.yml
     parameters:

src/signalrclient/logger.cpp

@@ -50,7 +50,7 @@ namespace signalr
 
                 // add millisecond part
                 // 5 = 3 digits of millisecond precision + 'Z' + null character ending
-                snprintf(timeString + sizeof(timeString) - 5, 5, "%03dZ", (int)milliseconds.count());
+                snprintf(timeString + sizeof(timeString) - 2, 5, "%03dZ", (int)milliseconds.count());
 
                 std::stringstream os;
                 os << timeString;