From fc5c959023c703ed371fbd0a588d7699dc3b8441 Mon Sep 17 00:00:00 2001
From: Maurice Prather <mprather@users.noreply.github.com>
Date: Mon, 16 Oct 2023 17:50:29 -0700
Subject: [PATCH 1/2] Updated get_callback_id, register_callback

Replaced the stringstream technique in get_callback_id with std::to_string.
Changed to emplace to avoid extra work with insert.
---
 src/signalrclient/callback_manager.cpp | 7 ++-----
 src/signalrclient/callback_manager.h   | 4 +++-
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/signalrclient/callback_manager.cpp b/src/signalrclient/callback_manager.cpp
index 1dc2876b..172601a4 100644
--- a/src/signalrclient/callback_manager.cpp
+++ b/src/signalrclient/callback_manager.cpp
@@ -26,8 +26,7 @@ namespace signalr
 
         {
             std::lock_guard<std::mutex> lock(m_map_lock);
-
-            m_callbacks.insert(std::make_pair(callback_id, callback));
+            m_callbacks.emplace(callback_id, callback);
         }
 
         return callback_id;
@@ -86,8 +85,6 @@ namespace signalr
     std::string callback_manager::get_callback_id()
     {
         const auto callback_id = m_id++;
-        std::stringstream ss;
-        ss << callback_id;
-        return ss.str();
+        return std::to_string(callback_id);
     }
 }
diff --git a/src/signalrclient/callback_manager.h b/src/signalrclient/callback_manager.h
index 3879cfbd..70be6fdd 100644
--- a/src/signalrclient/callback_manager.h
+++ b/src/signalrclient/callback_manager.h
@@ -5,9 +5,11 @@
 #pragma once
 
 #include <atomic>
-#include <unordered_map>
 #include <functional>
 #include <mutex>
+#include <string>
+#include <unordered_map>
+
 #include "signalrclient/signalr_value.h"
 
 namespace signalr

From 735ef8544ed6a9f3d2eb22800e44c1a56ea8738c Mon Sep 17 00:00:00 2001
From: Maurice Prather <mprather@users.noreply.github.com>
Date: Mon, 16 Oct 2023 19:35:37 -0700
Subject: [PATCH 2/2] Removed unused header

---
 src/signalrclient/callback_manager.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/signalrclient/callback_manager.cpp b/src/signalrclient/callback_manager.cpp
index 172601a4..ebcf05e5 100644
--- a/src/signalrclient/callback_manager.cpp
+++ b/src/signalrclient/callback_manager.cpp
@@ -4,7 +4,6 @@
 
 #include "stdafx.h"
 #include "callback_manager.h"
-#include <sstream>
 
 namespace signalr
 {