Skip to content

Commit 09c0404

Browse files
authored
[Blazor] OTEL feedback (#62836)
1 parent b568259 commit 09c0404

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/Components/Components/src/ComponentsActivitySource.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public static ComponentsActivityHandle StartHandleEventActivity(string? componen
7878
}
7979
if (methodName != null)
8080
{
81-
activity.SetTag("aspnetcore.components.method", methodName);
81+
activity.SetTag("code.function.name", methodName);
8282
}
8383
if (attributeName != null)
8484
{

src/Components/Components/src/ComponentsMetrics.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public async Task CaptureEventDuration(Task task, long startTimestamp, string? c
8383
var tags = new TagList
8484
{
8585
{ "aspnetcore.components.type", componentType ?? "unknown" },
86-
{ "aspnetcore.components.method", methodName ?? "unknown" },
86+
{ "code.function.name", methodName ?? "unknown" },
8787
{ "aspnetcore.components.attribute.name", attributeName ?? "unknown" }
8888
};
8989

@@ -104,7 +104,7 @@ public void FailEventSync(Exception ex, long startTimestamp, string? componentTy
104104
var tags = new TagList
105105
{
106106
{ "aspnetcore.components.type", componentType ?? "unknown" },
107-
{ "aspnetcore.components.method", methodName ?? "unknown" },
107+
{ "code.function.name", methodName ?? "unknown" },
108108
{ "aspnetcore.components.attribute.name", attributeName ?? "unknown" },
109109
{ "error.type", ex.GetType().FullName ?? "unknown" }
110110
};

src/Components/Components/test/ComponentsActivitySourceTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public void StartEventActivity_CreatesAndStartsActivity()
9696
Assert.Equal(ActivityKind.Internal, activity.Kind);
9797
Assert.True(activity.IsAllDataRequested);
9898
Assert.Equal(componentType, activity.GetTagItem("aspnetcore.components.type"));
99-
Assert.Equal(methodName, activity.GetTagItem("aspnetcore.components.method"));
99+
Assert.Equal(methodName, activity.GetTagItem("code.function.name"));
100100
Assert.Equal(attributeName, activity.GetTagItem("aspnetcore.components.attribute.name"));
101101
Assert.False(activity.IsStopped);
102102

src/Components/Components/test/ComponentsMetricsTest.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ await componentsMetrics.CaptureEventDuration(Task.CompletedTask, startTimestamp,
8787
Assert.Single(measurements);
8888
Assert.True(measurements[0].Value > 0);
8989
Assert.Equal("TestComponent", Assert.Contains("aspnetcore.components.type", measurements[0].Tags));
90-
Assert.Equal("OnClick", Assert.Contains("aspnetcore.components.method", measurements[0].Tags));
90+
Assert.Equal("OnClick", Assert.Contains("code.function.name", measurements[0].Tags));
9191
Assert.Equal("onclick", Assert.Contains("aspnetcore.components.attribute.name", measurements[0].Tags));
9292
Assert.DoesNotContain("error.type", measurements[0].Tags);
9393
}
@@ -112,7 +112,7 @@ await componentsMetrics.CaptureEventDuration(Task.FromException(new InvalidOpera
112112
Assert.Single(measurements);
113113
Assert.True(measurements[0].Value > 0);
114114
Assert.Equal("TestComponent", Assert.Contains("aspnetcore.components.type", measurements[0].Tags));
115-
Assert.Equal("OnClick", Assert.Contains("aspnetcore.components.method", measurements[0].Tags));
115+
Assert.Equal("OnClick", Assert.Contains("code.function.name", measurements[0].Tags));
116116
Assert.Equal("onclick", Assert.Contains("aspnetcore.components.attribute.name", measurements[0].Tags));
117117
Assert.Equal("System.InvalidOperationException", Assert.Contains("error.type", measurements[0].Tags));
118118
}
@@ -137,7 +137,7 @@ public void FailEventSync_RecordsErrorMetric()
137137
Assert.Single(measurements);
138138
Assert.True(measurements[0].Value > 0);
139139
Assert.Equal("TestComponent", Assert.Contains("aspnetcore.components.type", measurements[0].Tags));
140-
Assert.Equal("OnClick", Assert.Contains("aspnetcore.components.method", measurements[0].Tags));
140+
Assert.Equal("OnClick", Assert.Contains("code.function.name", measurements[0].Tags));
141141
Assert.Equal("onclick", Assert.Contains("aspnetcore.components.attribute.name", measurements[0].Tags));
142142
Assert.Equal("System.InvalidOperationException", Assert.Contains("error.type", measurements[0].Tags));
143143
}
@@ -372,7 +372,7 @@ await componentsMetrics.CaptureEventDuration(Task.CompletedTask, startTimestamp2
372372
// Check event duration
373373
Assert.True(eventMeasurements[0].Value > 0);
374374
Assert.Equal("TestComponent", Assert.Contains("aspnetcore.components.type", eventMeasurements[0].Tags));
375-
Assert.Equal("OnClick", Assert.Contains("aspnetcore.components.method", eventMeasurements[0].Tags));
375+
Assert.Equal("OnClick", Assert.Contains("code.function.name", eventMeasurements[0].Tags));
376376
Assert.Equal("onclick", Assert.Contains("aspnetcore.components.attribute.name", eventMeasurements[0].Tags));
377377

378378
// Check parameters duration

0 commit comments

Comments
 (0)