-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Labels
Pillar: Technical DebtPriority:1Work that is critical for the release, but we could probably ship withoutWork that is critical for the release, but we could probably ship withoutaffected-fewThis issue impacts only small number of customersThis issue impacts only small number of customersarea-blazorIncludes: Blazor, Razor ComponentsIncludes: Blazor, Razor ComponentsenhancementThis issue represents an ask for new feature or an enhancement to an existing oneThis issue represents an ask for new feature or an enhancement to an existing onefeature-blazor-builtin-componentsFeatures related to the built in components we ship or could ship in the futureFeatures related to the built in components we ship or could ship in the futurehelp candidateIndicates that the issues may be a good fit for community to help with. Requires work from eng. teamIndicates that the issues may be a good fit for community to help with. Requires work from eng. teamseverity-minorThis label is used by an internal toolThis label is used by an internal tool
Milestone
Description
Reported at #25817
When we implemented IAsyncDisposable
in components we should probably have also added support for this on OwningComponentBase
.
I'm not 100% certain whether adding it would count as a breaking change. To follow existing patterns, we'd want to implement IAsyncDisposable.DisposeAsync
explicitly and also add a protected virtual DisposeAsync(bool disposing)
, but that would likely clash with anybody's existing IAsyncDisposable
implementation in existing subclasses. People would have to change their IAsyncDisposable
implementations to override the new base-class DisposeAsync
method. So I guess it's quite breaking.
Metadata
Metadata
Assignees
Labels
Pillar: Technical DebtPriority:1Work that is critical for the release, but we could probably ship withoutWork that is critical for the release, but we could probably ship withoutaffected-fewThis issue impacts only small number of customersThis issue impacts only small number of customersarea-blazorIncludes: Blazor, Razor ComponentsIncludes: Blazor, Razor ComponentsenhancementThis issue represents an ask for new feature or an enhancement to an existing oneThis issue represents an ask for new feature or an enhancement to an existing onefeature-blazor-builtin-componentsFeatures related to the built in components we ship or could ship in the futureFeatures related to the built in components we ship or could ship in the futurehelp candidateIndicates that the issues may be a good fit for community to help with. Requires work from eng. teamIndicates that the issues may be a good fit for community to help with. Requires work from eng. teamseverity-minorThis label is used by an internal toolThis label is used by an internal tool