Min API validation extracts bad display name from DisplayAttribute

[sbomer]

For members with DisplayAttribute, this logic extracts the first named argument and uses it as the display name:

aspnetcore/src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/Extensions/ISymbolExtensions.cs

Lines 19 to 26 in 215bfd3

	if (displayNameAttribute.ConstructorArguments.Length > 0)
	{
	return displayNameAttribute.ConstructorArguments[0].Value?.ToString() ?? property.Name;
	}
	else if (displayNameAttribute.NamedArguments.Length > 0)
	{
	return displayNameAttribute.NamedArguments[0].Value.Value?.ToString() ?? property.Name;
	}

This chooses a bad display name when the attribute is used like this, for example:

        [Display(
            ResourceType = typeof(OptionsDisplayStrings),
            Description = nameof(OptionsDisplayStrings.DisplayAttributeDescription_CollectionRuleActionOptions_Name))]

The display name ends up as "Microsoft.Diagnostics.Monitoring.WebApi.OptionsDisplayString".

[mitchdenny]

@captainsafia can we close this one?