ValidatatableTypeAttribute does not work on records

[maartenvansambeek]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

When I decorate a record type with a [ValidatatableType] attribute, no validation information is generated for the type.

Expected Behavior

Both classes and records decorated with [ValidatableType] should cause validation information to be created.

Steps To Reproduce

Clone this repository: https://github.com/maartenvansambeek/validatabletype-on-records.git

Run dotnet build using .NET 10 preview 5.

Look at line 64 in the file:
obj\Debug\net10.0\generated\Microsoft.AspNetCore.Http.ValidationsGenerator\Microsoft.AspNetCore.Http.ValidationsGenerator.ValidationsGenerator\ValidatableInfoResolver.g.cs

See that information is generated for the class type, but not the records type in the project.

Exceptions (if any)

No response

.NET Version

10.0.100-preview.5.25277.114

Anything else?

No response

[marcominerva]

I too have experienced the same issue. /cc @captainsafia

[captainsafia]

@maartenvansambeek @marcominerva Thanks for reporting this issue and apologies for the delay in my response.

It appears that the root cause of the issue is in the check that we do here:

aspnetcore/src/Validation/gen/Parsers/ValidationsGenerator.AttributeParser.cs

Line 17 in e93c889

return syntaxNode is ClassDeclarationSyntax;

We should be able to resolve this issue by adding a || syntaxNode is RecordDeclarationSyntax check here and some test coverage.

I might not be able to get to a fix for a while but I'd be happy to review a PR from either of you given this is a should be a fairly small change.