From 0b86534a15162bc895a64f11e2840cfdb3eb8fe4 Mon Sep 17 00:00:00 2001 From: Dmitrii Korolev Date: Mon, 21 Jul 2025 20:50:42 +0200 Subject: [PATCH 1/6] browser-testing updates! --- .../70_browsertesting_update.yml | 44 +++++++++++++++++++ .../70_browsertesting_update_body.md | 20 +++++++++ .../workflows/browsertesting-open-issue.yml | 24 ++++++++++ 3 files changed, 88 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/70_browsertesting_update.yml create mode 100644 .github/ISSUE_TEMPLATE/70_browsertesting_update_body.md create mode 100644 .github/workflows/browsertesting-open-issue.yml diff --git a/.github/ISSUE_TEMPLATE/70_browsertesting_update.yml b/.github/ISSUE_TEMPLATE/70_browsertesting_update.yml new file mode 100644 index 000000000000..edf10f23008e --- /dev/null +++ b/.github/ISSUE_TEMPLATE/70_browsertesting_update.yml @@ -0,0 +1,44 @@ +name: "Request Dep Updates" +description: "Automated issue to update Browser-Testing dependencies" +title: "Request Browser-Testing Dependencies Update" +labels: + - dependencies + - automation + - selenium + - playwright +body: + - type: markdown + attributes: + value: | + This issue is configured to request an update of the Browser-Testing dependencies used in the project. + Copilot will automatically create a pull request to update the dependencies. + You can include more context to the issue description if you want to. + - type: textarea + id: update-notes + attributes: + label: Requested Browser-Testing Dependencies Update Notes + description: Adjust the description if you think it requires more context + # NOTE: update the `_body.md` as well if you are changing the text. + # It is used for automatic workflow of issue creation. + value: | + ## Description + + Selenium is used in the aspnetcore repo for automated E2E integration testing. + Playwright is used in the aspnetcore repo for some benchmarking apps. We need to ensure the docker file and the package version match. + + ## Instructions + + To update the Selenium and Playwright versions, these files need to be updated: + + ### Packages + - [ ] [Selenium in `Versions.props`](eng/Versions.props) from NuGet: + - [ ] [Selenium.WebDriver](https://www.nuget.org/packages/Selenium.WebDriver/) (Config variable `SeleniumWebDriverVersion`) + - [ ] [Selenium.Support](https://www.nuget.org/packages/Selenium.Support/) (Config variable `SeleniumSupportVersion`) + - [ ] Ensure Playwright versions match + - [ ] [Blazor Wasm benchmarks in `src/Components/benchmarkapps/Wasm.Performance/dockerfile`](src/Components/benchmarkapps/Wasm.Performance/dockerfile) (image starts with `mcr.microsoft.com`) + - [ ] [Playwright package version](eng/Versions.props) (Config variable `PlaywrightVersion`) + + ## Actions + + Please, open the PR against `main` branch and include changes to the files listed above. + diff --git a/.github/ISSUE_TEMPLATE/70_browsertesting_update_body.md b/.github/ISSUE_TEMPLATE/70_browsertesting_update_body.md new file mode 100644 index 000000000000..ddc61ffc7534 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/70_browsertesting_update_body.md @@ -0,0 +1,20 @@ +## Description + +Selenium is used in the aspnetcore repo for automated E2E integration testing. +Playwright is used in the aspnetcore repo for some benchmarking apps. We need to ensure the docker file and the package version match. + +## Instructions + +To update the Selenium and Playwright versions, these files need to be updated: + +### Packages + - [ ] [Selenium in `Versions.props`](eng/Versions.props) from NuGet: + - [ ] [Selenium.WebDriver](https://www.nuget.org/packages/Selenium.WebDriver/) (Config variable `SeleniumWebDriverVersion`) + - [ ] [Selenium.Support](https://www.nuget.org/packages/Selenium.Support/) (Config variable `SeleniumSupportVersion`) + - [ ] Ensure Playwright versions match + - [ ] [Blazor Wasm benchmarks in `src/Components/benchmarkapps/Wasm.Performance/dockerfile`](src/Components/benchmarkapps/Wasm.Performance/dockerfile) (image starts with `mcr.microsoft.com`) + - [ ] [Playwright package version](eng/Versions.props) (Config variable `PlaywrightVersion`) + +## Actions + +Please, open the PR against `main` branch and include changes to the files listed above. diff --git a/.github/workflows/browsertesting-open-issue.yml b/.github/workflows/browsertesting-open-issue.yml new file mode 100644 index 000000000000..2f886f7e0c57 --- /dev/null +++ b/.github/workflows/browsertesting-open-issue.yml @@ -0,0 +1,24 @@ +name: "[Monthly] Schedule Browser-Testing Dependencies Update Issue" + +on: + schedule: + # Runs on the first day of every month at midnight UTC + - cron: '0 0 1 * *' + workflow_dispatch: + +jobs: + create-issue: + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Create Issue From Template + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GH_REPO: ${{ github.repository }} + run: | + gh issue create \ + --title "Request Browser-Testing Dependencies Update" \ + --body-file ".github/ISSUE_TEMPLATE/70_browsertesting_update_body.md" \ + --assignee "@copilot" From 9dc162aeffc49f5641d597ab43ae7481b50a496e Mon Sep 17 00:00:00 2001 From: Dmitrii Korolev Date: Mon, 21 Jul 2025 20:51:46 +0200 Subject: [PATCH 2/6] add doc --- .github/workflows/browsertesting-open-issue.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/browsertesting-open-issue.yml b/.github/workflows/browsertesting-open-issue.yml index 2f886f7e0c57..7c2eb460b109 100644 --- a/.github/workflows/browsertesting-open-issue.yml +++ b/.github/workflows/browsertesting-open-issue.yml @@ -13,6 +13,8 @@ jobs: - name: Checkout repository uses: actions/checkout@v4 + # copilot can be assigned to the issue + # https://cli.github.com/manual/gh_issue_create - name: Create Issue From Template env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 8d9eedfeba4e2a44230cb2043aca3f200ea48dd5 Mon Sep 17 00:00:00 2001 From: Dmitrii Korolev Date: Mon, 21 Jul 2025 20:53:03 +0200 Subject: [PATCH 3/6] explain --- .github/workflows/browsertesting-open-issue.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/browsertesting-open-issue.yml b/.github/workflows/browsertesting-open-issue.yml index 7c2eb460b109..a4925995a83f 100644 --- a/.github/workflows/browsertesting-open-issue.yml +++ b/.github/workflows/browsertesting-open-issue.yml @@ -4,7 +4,7 @@ on: schedule: # Runs on the first day of every month at midnight UTC - cron: '0 0 1 * *' - workflow_dispatch: + workflow_dispatch: # for manual triggering jobs: create-issue: From fe5df3334606bb2524bc17c4e0b772faa684fa34 Mon Sep 17 00:00:00 2001 From: Dmitrii Korolev Date: Mon, 21 Jul 2025 21:00:16 +0200 Subject: [PATCH 4/6] fix naming --- .github/ISSUE_TEMPLATE/70_browsertesting_update.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/70_browsertesting_update.yml b/.github/ISSUE_TEMPLATE/70_browsertesting_update.yml index edf10f23008e..f83749862129 100644 --- a/.github/ISSUE_TEMPLATE/70_browsertesting_update.yml +++ b/.github/ISSUE_TEMPLATE/70_browsertesting_update.yml @@ -1,4 +1,4 @@ -name: "Request Dep Updates" +name: "Request Browser-Testing Dependencies Update" description: "Automated issue to update Browser-Testing dependencies" title: "Request Browser-Testing Dependencies Update" labels: From 7eb31e06359e95e5bcc150efb6ad761586f79f07 Mon Sep 17 00:00:00 2001 From: Dmitrii Korolev Date: Tue, 22 Jul 2025 11:15:39 +0200 Subject: [PATCH 5/6] simplify --- .../70_browsertesting_update.yml | 44 ------------------- .../browsertesting-issue-body.md} | 0 .../workflows/browsertesting-open-issue.yml | 2 +- 3 files changed, 1 insertion(+), 45 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/70_browsertesting_update.yml rename .github/{ISSUE_TEMPLATE/70_browsertesting_update_body.md => workflows/browsertesting-issue-body.md} (100%) diff --git a/.github/ISSUE_TEMPLATE/70_browsertesting_update.yml b/.github/ISSUE_TEMPLATE/70_browsertesting_update.yml deleted file mode 100644 index f83749862129..000000000000 --- a/.github/ISSUE_TEMPLATE/70_browsertesting_update.yml +++ /dev/null @@ -1,44 +0,0 @@ -name: "Request Browser-Testing Dependencies Update" -description: "Automated issue to update Browser-Testing dependencies" -title: "Request Browser-Testing Dependencies Update" -labels: - - dependencies - - automation - - selenium - - playwright -body: - - type: markdown - attributes: - value: | - This issue is configured to request an update of the Browser-Testing dependencies used in the project. - Copilot will automatically create a pull request to update the dependencies. - You can include more context to the issue description if you want to. - - type: textarea - id: update-notes - attributes: - label: Requested Browser-Testing Dependencies Update Notes - description: Adjust the description if you think it requires more context - # NOTE: update the `_body.md` as well if you are changing the text. - # It is used for automatic workflow of issue creation. - value: | - ## Description - - Selenium is used in the aspnetcore repo for automated E2E integration testing. - Playwright is used in the aspnetcore repo for some benchmarking apps. We need to ensure the docker file and the package version match. - - ## Instructions - - To update the Selenium and Playwright versions, these files need to be updated: - - ### Packages - - [ ] [Selenium in `Versions.props`](eng/Versions.props) from NuGet: - - [ ] [Selenium.WebDriver](https://www.nuget.org/packages/Selenium.WebDriver/) (Config variable `SeleniumWebDriverVersion`) - - [ ] [Selenium.Support](https://www.nuget.org/packages/Selenium.Support/) (Config variable `SeleniumSupportVersion`) - - [ ] Ensure Playwright versions match - - [ ] [Blazor Wasm benchmarks in `src/Components/benchmarkapps/Wasm.Performance/dockerfile`](src/Components/benchmarkapps/Wasm.Performance/dockerfile) (image starts with `mcr.microsoft.com`) - - [ ] [Playwright package version](eng/Versions.props) (Config variable `PlaywrightVersion`) - - ## Actions - - Please, open the PR against `main` branch and include changes to the files listed above. - diff --git a/.github/ISSUE_TEMPLATE/70_browsertesting_update_body.md b/.github/workflows/browsertesting-issue-body.md similarity index 100% rename from .github/ISSUE_TEMPLATE/70_browsertesting_update_body.md rename to .github/workflows/browsertesting-issue-body.md diff --git a/.github/workflows/browsertesting-open-issue.yml b/.github/workflows/browsertesting-open-issue.yml index a4925995a83f..4f8b49e20920 100644 --- a/.github/workflows/browsertesting-open-issue.yml +++ b/.github/workflows/browsertesting-open-issue.yml @@ -22,5 +22,5 @@ jobs: run: | gh issue create \ --title "Request Browser-Testing Dependencies Update" \ - --body-file ".github/ISSUE_TEMPLATE/70_browsertesting_update_body.md" \ + --body-file ".github/workflows/browsertesting-issue-body.md" \ --assignee "@copilot" From f7bb64e517b1bfd6768ef5448926ada950576376 Mon Sep 17 00:00:00 2001 From: Dmitrii Korolev Date: Wed, 23 Jul 2025 10:33:57 +0200 Subject: [PATCH 6/6] update --- .github/workflows/browsertesting-issue-body.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/browsertesting-issue-body.md b/.github/workflows/browsertesting-issue-body.md index ddc61ffc7534..eb3780f32a8c 100644 --- a/.github/workflows/browsertesting-issue-body.md +++ b/.github/workflows/browsertesting-issue-body.md @@ -18,3 +18,4 @@ To update the Selenium and Playwright versions, these files need to be updated: ## Actions Please, open the PR against `main` branch and include changes to the files listed above. +Also mention @dotnet/aspnet-build in the opened Pull Request - this will be a responsible engineer for changes validation.