From e373af879ab21420f27e23b4511be8dee2048098 Mon Sep 17 00:00:00 2001 From: Andrew Arnott Date: Sun, 3 Aug 2025 09:21:12 -0600 Subject: [PATCH] Improve nullable annotation on CancelInvocationMessage.InvocationId This declares a `new` property for `string InvocationId { get; }` so that the compiler sees it as non-nullable, consistent with the constructor declared on the same type. --- .../SignalR.Common/src/Protocol/CancelInvocationMessage.cs | 3 +++ .../src/PublicAPI/net10.0/PublicAPI.Unshipped.txt | 1 + .../src/PublicAPI/net462/PublicAPI.Unshipped.txt | 1 + .../src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt | 1 + 4 files changed, 6 insertions(+) diff --git a/src/SignalR/common/SignalR.Common/src/Protocol/CancelInvocationMessage.cs b/src/SignalR/common/SignalR.Common/src/Protocol/CancelInvocationMessage.cs index 5cc9dba052a1..09bd117e6613 100644 --- a/src/SignalR/common/SignalR.Common/src/Protocol/CancelInvocationMessage.cs +++ b/src/SignalR/common/SignalR.Common/src/Protocol/CancelInvocationMessage.cs @@ -17,4 +17,7 @@ public class CancelInvocationMessage : HubInvocationMessage public CancelInvocationMessage(string invocationId) : base(invocationId) { } + + /// + public new string InvocationId => base.InvocationId!; } diff --git a/src/SignalR/common/SignalR.Common/src/PublicAPI/net10.0/PublicAPI.Unshipped.txt b/src/SignalR/common/SignalR.Common/src/PublicAPI/net10.0/PublicAPI.Unshipped.txt index 7dc5c58110bf..a98f1485fa2d 100644 --- a/src/SignalR/common/SignalR.Common/src/PublicAPI/net10.0/PublicAPI.Unshipped.txt +++ b/src/SignalR/common/SignalR.Common/src/PublicAPI/net10.0/PublicAPI.Unshipped.txt @@ -1 +1,2 @@ #nullable enable +Microsoft.AspNetCore.SignalR.Protocol.CancelInvocationMessage.InvocationId.get -> string! diff --git a/src/SignalR/common/SignalR.Common/src/PublicAPI/net462/PublicAPI.Unshipped.txt b/src/SignalR/common/SignalR.Common/src/PublicAPI/net462/PublicAPI.Unshipped.txt index 7dc5c58110bf..a98f1485fa2d 100644 --- a/src/SignalR/common/SignalR.Common/src/PublicAPI/net462/PublicAPI.Unshipped.txt +++ b/src/SignalR/common/SignalR.Common/src/PublicAPI/net462/PublicAPI.Unshipped.txt @@ -1 +1,2 @@ #nullable enable +Microsoft.AspNetCore.SignalR.Protocol.CancelInvocationMessage.InvocationId.get -> string! diff --git a/src/SignalR/common/SignalR.Common/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt b/src/SignalR/common/SignalR.Common/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt index 7dc5c58110bf..a98f1485fa2d 100644 --- a/src/SignalR/common/SignalR.Common/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt +++ b/src/SignalR/common/SignalR.Common/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt @@ -1 +1,2 @@ #nullable enable +Microsoft.AspNetCore.SignalR.Protocol.CancelInvocationMessage.InvocationId.get -> string!