Send 403 when trying to delete lock owned by other user without force=true

slonopotamus · slonopotamus · commit bd425da8de23 · 2019-05-20T15:09:40.000+03:00
diff --git a/gitlfs-server/src/main/java/ru/bozaro/gitlfs/server/LocksServlet.java b/gitlfs-server/src/main/java/ru/bozaro/gitlfs/server/LocksServlet.java
@@ -94,7 +94,7 @@ private ResponseWriter deleteLock(@NotNull HttpServletRequest req, @NotNull Lock
 
       return new ObjectResponse(HttpServletResponse.SC_OK, new CreateLockRes(lock));
     } catch (LockConflictException e) {
-      return new ObjectResponse(HttpServletResponse.SC_CONFLICT, new CreateLockRes(e.getLock()));
+      return new ObjectResponse(HttpServletResponse.SC_FORBIDDEN, new CreateLockRes(e.getLock()));
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ private ResponseWriter deleteLock(@NotNull HttpServletRequest req, @NotNull Lock`
`94`	`94`
`95`	`95`	`return new ObjectResponse(HttpServletResponse.SC_OK, new CreateLockRes(lock));`
`96`	`96`	`} catch (LockConflictException e) {`
`97`		`- return new ObjectResponse(HttpServletResponse.SC_CONFLICT, new CreateLockRes(e.getLock()));`
	`97`	`+ return new ObjectResponse(HttpServletResponse.SC_FORBIDDEN, new CreateLockRes(e.getLock()));`
`98`	`98`	`}`
`99`	`99`	`}`
`100`	`100`