LoggingOptions.getDefaultInstance() always returns a new object

[alamothe]

LoggingOptions.getDefaultInstance() always returns a new object:

  public static LoggingOptions getDefaultInstance() {
    return newBuilder().build();
  }

This is very misleading, because the method name suggests it will return the same instance.

Consequences are that Logging instance is not shared among handlers etc. if we use LoggingOptions.getDefaultInstance() to pass the options, without saving them to a variable.

In fact, our codebase had LoggingOptions.getDefaultInstance().service in a few places, and a new client was always created as a result.

[minherz]

Thank you for raising this problem. The method returns a new instance of the LoggingOptions instance with default setup.
I understand the source of the confusion. The consecutive calls to the loggingOptions.getService() will return the same service instance which, in our case will be Logging instance. However, consecutive calls to the LoggingOptions.getDefaultInstance().getService() will indeed return each time a new instance of the Logging implementation.
Unfortunately, we do not have information how many our customers use the fact that the call to the LoggingOptions.getDefaultInstance() returns a new instance of the LoggingOptions. In result, we cannot modify this behavior without introducing a breaking change.
We will certainly make this change in the next major version.

[losalex]

Lowering the priority to consider it in next release