From ffb38bb3836417f823c5ea570909b12197c5f228 Mon Sep 17 00:00:00 2001
From: Pushpak Chhajed <pushpak1300@gmail.com>
Date: Tue, 12 Aug 2025 09:17:19 +0530
Subject: [PATCH] refactor: improve readability and consistency in
 BoostServiceProvider

- Update docblock annotations for clarity.
- Merge `match` statement cases for concise handling.
- Adjust visibility of `registerBladeDirectives` to private.
---
 src/BoostServiceProvider.php | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/src/BoostServiceProvider.php b/src/BoostServiceProvider.php
index ce5e9fe..e8fa758 100644
--- a/src/BoostServiceProvider.php
+++ b/src/BoostServiceProvider.php
@@ -6,6 +6,7 @@
 
 use Illuminate\Foundation\Http\Middleware\VerifyCsrfToken;
 use Illuminate\Http\Request;
+use Illuminate\Log\Logger;
 use Illuminate\Routing\Router;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\Route;
@@ -69,7 +70,7 @@ public function boot(Router $router): void
         $this->hookIntoResponses($router);
     }
 
-    protected function registerPublishing(): void
+    private function registerPublishing(): void
     {
         if ($this->app->runningInConsole()) {
             $this->publishes([
@@ -78,7 +79,7 @@ protected function registerPublishing(): void
         }
     }
 
-    protected function registerCommands(): void
+    private function registerCommands(): void
     {
         if ($this->app->runningInConsole()) {
             $this->commands([
@@ -93,14 +94,14 @@ private function registerRoutes(): void
     {
         Route::post('/_boost/browser-logs', function (Request $request) {
             $logs = $request->input('logs', []);
-            /** @var \Illuminate\Log\Logger $logger */
+            /** @var Logger $logger */
             $logger = Log::channel('browser');
 
             /**
              *  @var array{
              *      type: 'error'|'warn'|'info'|'log'|'table'|'window_error'|'uncaught_error'|'unhandled_rejection',
              *      timestamp: string,
-             *      data: array<mixed>,
+             *      data: array,
              *      url:string,
              *      userAgent:string
              *  } $log */
@@ -123,13 +124,13 @@ private function registerRoutes(): void
     }
 
     /**
-     * Build a string message for the log based on various input types. Single dimensional, and multi:
-     * "data":[
-     * {"message":"Unhandled Promise Rejection","reason":{"name":"TypeError","message":"NetworkError when attempting to fetch resource.","stack":""}}]
+     * Build a string message for the log based on various input types. Single-dimensional, and multi:
+     * "data": {"message":"Unhandled Promise Rejection","reason":{"name":"TypeError","message":"NetworkError when attempting to fetch resource.","stack":""}}]
      *
-     * @param array<mixed> $data
+     * @param array $data
+     * @return string
      */
-    protected function buildLogMessageFromData(array $data): string
+    private function buildLogMessageFromData(array $data): string
     {
         $messages = [];
 
@@ -146,7 +147,7 @@ protected function buildLogMessageFromData(array $data): string
         return implode(' ', $messages);
     }
 
-    protected function registerBrowserLogger(): void
+    private function registerBrowserLogger(): void
     {
         config([
             'logging.channels.browser' => [
@@ -158,7 +159,7 @@ protected function registerBrowserLogger(): void
         ]);
     }
 
-    protected function registerBladeDirectives(BladeCompiler $bladeCompiler): void
+    private function registerBladeDirectives(BladeCompiler $bladeCompiler): void
     {
         $bladeCompiler->directive('boostJs', fn () => '<?php echo \\Laravel\\Boost\\Services\\BrowserLogger::getScript(); ?>');
     }
@@ -167,11 +168,8 @@ private function mapJsTypeToPsr3Level(string $type): string
     {
         return match ($type) {
             'warn' => 'warning',
-            'log' => 'debug',
-            'table' => 'debug',
-            'window_error' => 'error',
-            'uncaught_error' => 'error',
-            'unhandled_rejection' => 'error',
+            'log', 'table' => 'debug',
+            'window_error', 'uncaught_error', 'unhandled_rejection' => 'error',
             default => $type
         };
     }