Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: morristech/clean-code-javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ryanmcdermott/clean-code-javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 19 commits
  • 1 file changed
  • 9 contributors

Commits on Jan 21, 2020

  1. Configuration menu
    Copy the full SHA
    8491866 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Merge pull request ryanmcdermott#288 from sbimochan/patch-1

    Change argument name from inner variable name
    ryanmcdermott authored Jul 31, 2020
    Configuration menu
    Copy the full SHA
    4d15e1c View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2020

  1. Configuration menu
    Copy the full SHA
    365717f View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Replace pass-by-reference with mutability, clean up

    This edit only affects the Avoid Side Effects (part 2) section.
    It replaces the discussion of pass by reference with an explanation in terms of mutability. 
    By avoiding the confusing terminology and possible links to the implementation details of 
    different JS engines the explanation can be kept at an abstraction level that's great for 
    beginners and experts alike. I also cleaned up some grammar, typos, etc.
    jdsandifer authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    3b9504e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Merge pull request ryanmcdermott#323 from jdsandifer/issue-321-remove…

    …-pass-by-reference
    
    Replace pass-by-reference with mutability, clean up
    ryanmcdermott authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    597a510 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Merge pull request ryanmcdermott#320 from ychek/add-calculation-for-m…

    …illiseconds
    
    Add calculation for milliseconds in a day
    ryanmcdermott authored Oct 7, 2020
    Configuration menu
    Copy the full SHA
    8f678c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Configuration menu
    Copy the full SHA
    3028219 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ryanmcdermott#325 from jdsandifer/issue-321-remove…

    …-pass-by-reference
    
    Fix stray hyphen turning into a random bullet
    ryanmcdermott authored Oct 8, 2020
    Configuration menu
    Copy the full SHA
    ca37c9c View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Configuration menu
    Copy the full SHA
    029c4c2 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Merge pull request ryanmcdermott#326 from doskovicmilos/patch-1

    Add Serbian translation.
    ryanmcdermott authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    da76556 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Make example more succinct

    "PER" has the same meaning as "IN_A" but is less verbose
    jamestharpe authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    753d6d8 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2021

  1. Merge pull request ryanmcdermott#341 from jamestharpe/patch-1

    Make example more succinct
    ryanmcdermott authored May 23, 2021
    Configuration menu
    Copy the full SHA
    20563d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ff9eba View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Configuration menu
    Copy the full SHA
    384665f View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. French translation

    eugene-augier authored Apr 13, 2022
    Configuration menu
    Copy the full SHA
    98f1d4a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2022

  1. fixed naming

    agilatakishiyev committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    2cab77b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2022

  1. Merge pull request ryanmcdermott#392 from agilatakishiyev/master

    Fix wrong naming of `default parameters`
    ryanmcdermott authored Aug 21, 2022
    Configuration menu
    Copy the full SHA
    5b49d62 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ryanmcdermott#383 from eugene-augier/french-transl…

    …ation
    
    French translation
    ryanmcdermott authored Aug 21, 2022
    Configuration menu
    Copy the full SHA
    a4c884f View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. Merge pull request ryanmcdermott#356 from hamettio/master

    Persian translation added (Fluent + RTL styled)
    ryanmcdermott authored Feb 11, 2023
    Configuration menu
    Copy the full SHA
    5311f64 View commit details
    Browse the repository at this point in the history
Loading