When using CreatedAtAction and Guid as Id, I get "System.InvalidOperationException: No route matches the supplied values."

[mattiasw2]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

I had to replace

       CreatedAtAction(nameof(GetTodoItem), new { id = todoItem.Id });

by explicit

        var url = Url.Action(nameof(GetTodoItem), new { id = todoItem.Id });
        return Created(url, todoItem);

In order to not get "System.InvalidOperationException: No route matches the supplied values." when posting

{ "Title":"Task One", "IsComplete": false }

I assume the problem is that the Guid somehow.

The code is

    public class TodoItem
    {
        [Required]
        public Guid Id { get; init; }

        [Required]
        [StringLength(255)]
        public string Title { get; init; }

        [Required]
        public bool IsComplete { get; init; }
    }
    
        public async Task<ActionResult<TodoItem>> PostTodoItem(TodoItem todoItem)
        {
            context.TodoItems.Add(todoItem);
            try
            {
                await context.SaveChangesAsync();
            }
            catch (DbUpdateException)
            {
                if (TodoItemExists(todoItem.Id))
                {
                    return Conflict();
                }
                else
                {
                    throw;
                }
            }

            return CreatedAtAction(nameof(GetTodoItem), new { id = todoItem.Id });
         }

Expected Behavior

I expected CreatedAtAction to work as the more explicit code.

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

8.0.204

Anything else?

aspnet core 8.0.4

[martincostello]

What does the code for the GetTodoItem endpoint look like so we can see how its route is defined?

[mattiasw2]

    [Route("api/[controller]")]
    [ApiController]
    public class TodoItemsController(AppDbContext context) : ControllerBase
    {
        // GET: api/TodoItems
        [HttpGet]
        public async Task<ActionResult<IEnumerable<TodoItem>>> GetTodoItems()
        {
            return await context.TodoItems.ToListAsync();
        }

        // GET: api/TodoItems/5
        [HttpGet("{id}")]
        public async Task<ActionResult<TodoItem>> GetTodoItem(Guid id)
        {
            var todoItem = await context.TodoItems.FindAsync(id);

            if (todoItem == null)
            {
                return NotFound();
            }

            return todoItem;
        }

[martincostello]

Does it work if you change the route template to [HttpGet("{id:guid}")]?

[mattiasw2]

No, [HttpGet("{id:guid}")] doesn't help.

[mrememisaac]

This is still an issue. @mattiasw2 your workaround is still well working, thank you.

net9.0

[captainsafia]

I believe the issue here is the fact that the Id property on the TodoItem is not provided in the value you are sending:

{ "Title":"Task One", "IsComplete": false }

In this case, the IOE you are getting is related to the missing ID.

[dotnet-policy-service]

This issue has been resolved and has not had any activity for 1 day. It will be closed for housekeeping purposes.

See our Issue Management Policies for more information.