-
Notifications
You must be signed in to change notification settings - Fork 6k
Add generic type argument accessibility example to CS0050 documentation #47705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
2
commits into
main
Choose a base branch
from
copilot/fix-31062
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -12,7 +12,7 @@ ms.assetid: dead2d28-f4db-4afe-b8dd-38968625f7c3 | |||
|
||||
Inconsistent accessibility: return type 'type' is less accessible than method 'method' | ||||
|
||||
The return type and each of the types referenced in the formal parameter list of a method must be at least as accessible as the method itself. For more information, see [Access Modifiers](../../programming-guide/classes-and-structs/access-modifiers.md). | ||||
The return type and each of the types referenced in the formal parameter list of a method must be at least as accessible as the method itself. This includes type arguments of generic types used in the return type or parameters. For more information, see [Access Modifiers](../../programming-guide/classes-and-structs/access-modifiers.md). | ||||
|
||||
## Example | ||||
|
||||
|
@@ -36,3 +36,45 @@ public class MyClass2 | |||
public static void Main() { } | ||||
} | ||||
``` | ||||
|
||||
## Another cause | ||||
|
||||
Comment on lines
+40
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
CS0050 can also occur when a generic type's type argument is less accessible than the method: | ||||
|
||||
```csharp | ||||
// CS0050_Generic.cs | ||||
using System.Collections.ObjectModel; | ||||
|
||||
internal class CeisData // Internal class | ||||
{ | ||||
public string Name { get; set; } | ||||
} | ||||
|
||||
public class MyClass | ||||
{ | ||||
public static ObservableCollection<CeisData> BuildCeis() // CS0050 | ||||
{ | ||||
return new ObservableCollection<CeisData>(); | ||||
} | ||||
} | ||||
``` | ||||
|
||||
To fix this error, make the type argument at least as accessible as the method: | ||||
|
||||
```csharp | ||||
// Fixed version | ||||
using System.Collections.ObjectModel; | ||||
|
||||
public class CeisData // Now public | ||||
{ | ||||
public string Name { get; set; } | ||||
} | ||||
|
||||
public class MyClass | ||||
{ | ||||
public static ObservableCollection<CeisData> BuildCeis() // OK | ||||
{ | ||||
return new ObservableCollection<CeisData>(); | ||||
} | ||||
} | ||||
``` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.