Skip to content

Use refactored search adapter #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Mar 30, 2022

Conversation

maudetes
Copy link
Contributor

@maudetes maudetes commented Jan 6, 2022

Fix datagouv/data.gouv.fr#588

Following opendatateam/udata#2692, we use the refactored search adapter.

Default lists page without query (/fr/datasets/) has the same behavior as previously.

We are merging on the new use-search-v2 branch and not directly on master.

@maudetes maudetes marked this pull request as draft January 6, 2022 15:58
@maudetes maudetes changed the title WIP: Use refactored search adaptater for lists WIP: Use refactored search adapter Jan 6, 2022
Copy link
Contributor

@nicolaskempf57 nicolaskempf57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at the files and didn't test it on local yet.

@maudetes maudetes changed the base branch from master to use-search-v2 February 3, 2022 13:45
@maudetes maudetes changed the title WIP: Use refactored search adapter Use refactored search adapter Feb 3, 2022
@maudetes maudetes marked this pull request as ready for review February 3, 2022 13:47
@maudetes maudetes requested a review from nicolaskempf57 March 3, 2022 17:25
@maudetes
Copy link
Contributor Author

Changes on suggest will be obsolete after #88.

@maudetes maudetes requested a review from nicolaskempf57 March 28, 2022 11:50
@maudetes maudetes changed the base branch from use-search-v2 to master March 29, 2022 16:14
@maudetes maudetes merged commit 74486df into datagouv:master Mar 30, 2022
@maudetes maudetes deleted the feat/use-refactored-search-adapter branch March 30, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remplacer les appels à la recherche depuis le front
2 participants