fix: Prevent install command from breaking when /tests doesn't exist

[sagalbot]

Currently, on v1.0.9, php artisan boost:install will fail for any project that doesn't contain a tests directory at the root of the project.

~/Sites/central install-laravel-boost* 20s
❯ php artisan boost:install

 ██████╗   ██████╗   ██████╗  ███████╗ ████████╗
 ██╔══██╗ ██╔═══██╗ ██╔═══██╗ ██╔════╝ ╚══██╔══╝
 ██████╔╝ ██║   ██║ ██║   ██║ ███████╗    ██║
 ██╔══██╗ ██║   ██║ ██║   ██║ ╚════██║    ██║
 ██████╔╝ ╚██████╔╝ ╚██████╔╝ ███████║    ██║
 ╚═════╝   ╚═════╝   ╚═════╝  ╚══════╝    ╚═╝

  ✦ Laravel Boost :: Install :: We Must Ship ✦ 

 Let's give Redacted Project Name a Boost

Symfony\Component\Finder\Exception\DirectoryNotFoundException 

The "/Users/sagalbot/Sites/central/tests" directory does not exist.

at vendor/symfony/finder/Finder.php:646
  642▕             } elseif ($glob = glob($dir, (\defined('GLOB_BRACE') ? \GLOB_BRACE : 0) | \GLOB_ONLYDIR | \GLOB_NOSORT)) {
  643▕                 sort($glob);
  644▕                 $resolvedDirs[] = array_map($this->normalizeDir(...), $glob);
  645▕             } else {
➜ 646▕                 throw new DirectoryNotFoundException(\sprintf('The "%s" directory does not exist.', $dir));
  647▕             }
  648▕         }
  649▕ 
  650▕         $this->dirs = array_merge($this->dirs, ...$resolvedDirs);

    +15 vendor frames 

16  artisan:35
    Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

The installer looks for tests within the directory to determine if the user should be prompted about AI writing tests. The strategy here makes sense - remove an install step if no tests are found, but the current implementation will fail for many projects.

I think the simplest possible solution here is to just ask the user. Yes, it's one extra step, but it puts control in the hands of the user. If you're installing into a fresh Laravel project, the arbitrary 6 test threshold means you won't be asked about AI test guidelines.

If you do want to use the presence of tests as a way to determine if this question should be asked, you could call phpunit --list-tests and check if the output is >=6 lines. That should work for jest and phpunit regardless of test ___location.

Changes

• removes check for /tests (fixes install failure)
• changes flow so asking is the last step

Resolves #45

[sagalbot]

I just noticed that the current flow is set to never ask and have $enforceTests always true. Easier fix - just delete the method and the call? Let me know and I can update the PR.

[pushpak1300]

@sagalbot
Initially, we're aiming to keep the number of questions during installation to a minimum, which is why we have the ask option available but haven't enabled it yet.
I was thinking if we could make the failure avoid when the test directory doesn't exist. For example, we could implement something like this:

$testsPath = base_path('tests');
$hasMinimumTests = false;
if (is_dir($testsPath)) {
    $hasMinimumTests = Finder::create()
        ->in($testsPath)
        ->files()
        ->name('*.php')
        ->count() > 6;
}

What do you think about this suggestion?

[ashleyhindle]

This would be my preference too for right now, checking if tests exists before searching.

We added the ask option because we do want to ask at some point when needed, but it's a bit in the way at the minute and we need to find a better DX for that & other questions 👌

[pushpak1300]

@ashleyhindle I have tested this locally.

LGTM 🚀

[ashleyhindle]

Thanks @sagalbot, you're the best 🫶