Skip to content

[kube-prometheus-stack] Allow to set a timezone for the default grafana dashboards #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 20, 2021
Merged

Conversation

krufab
Copy link
Contributor

@krufab krufab commented Sep 8, 2021

What this PR does / why we need it:

Allow to set a timezone for the default grafana dashboards.

The default dashboards have different timezones (utc, UTC, browser) and are loaded as read only in Grafana. Therefore, any change the user performs regarding the timezone, it cannot be saved.
This MR gives the user the possibility to set the some default timezone for all the dashboards (i.e. his / her own local timezone), without the need of modifying them.

Which issue this PR fixes

Fixes #780

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: Fabio Kruger [email protected]

Signed-off-by: Fabio Kruger <[email protected]>

# Conflicts:
#	charts/kube-prometheus-stack/Chart.yaml
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
@krufab krufab requested a review from vsliouniaev September 16, 2021 19:21
vsliouniaev
vsliouniaev previously approved these changes Sep 17, 2021
Signed-off-by: Fabio Kruger <[email protected]>
@krufab krufab requested a review from vsliouniaev September 17, 2021 22:19
vsliouniaev
vsliouniaev previously approved these changes Sep 20, 2021
Signed-off-by: Fabio Kruger <[email protected]>
@krufab krufab requested a review from vsliouniaev September 20, 2021 12:54
@vsliouniaev vsliouniaev merged commit afb7e59 into prometheus-community:main Sep 20, 2021
@krufab krufab deleted the feature/timezone-fix branch September 21, 2021 20:08
QuentinBisson pushed a commit to giantswarm/prometheus-community-helm-charts-upstream that referenced this pull request Oct 5, 2021
…na dashboards (prometheus-community#1326)

* Allow to set a timezone for the default grafana dashboards

Signed-off-by: Fabio Kruger <[email protected]>

* Updated chart version

Signed-off-by: Fabio Kruger <[email protected]>

* prometheus-community#780 Improved regex

Signed-off-by: Fabio Kruger <[email protected]>

* prometheus-community#780 Improved regex

Signed-off-by: Fabio Kruger <[email protected]>

* prometheus-community#780 Improved regex

Signed-off-by: Fabio Kruger <[email protected]>

* prometheus-community#780 Improved regex

Signed-off-by: Fabio Kruger <[email protected]>

* prometheus-community#780 Improved regex

Signed-off-by: Fabio Kruger <[email protected]>

* Corrected typo in the regex replace value

Signed-off-by: Fabio Kruger <[email protected]>

* Version bump

Signed-off-by: Fabio Kruger <[email protected]>

* Corrected typos

Signed-off-by: Fabio Kruger <[email protected]>

* Varsion bump

Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: QuentinBisson <[email protected]>
stamzid pushed a commit to Unstructured-IO/prometheus-community-helm-charts that referenced this pull request Mar 3, 2023
…na dashboards (prometheus-community#1326)

* Allow to set a timezone for the default grafana dashboards

Signed-off-by: Fabio Kruger <[email protected]>

* Updated chart version

Signed-off-by: Fabio Kruger <[email protected]>

* prometheus-community#780 Improved regex

Signed-off-by: Fabio Kruger <[email protected]>

* prometheus-community#780 Improved regex

Signed-off-by: Fabio Kruger <[email protected]>

* prometheus-community#780 Improved regex

Signed-off-by: Fabio Kruger <[email protected]>

* prometheus-community#780 Improved regex

Signed-off-by: Fabio Kruger <[email protected]>

* prometheus-community#780 Improved regex

Signed-off-by: Fabio Kruger <[email protected]>

* Corrected typo in the regex replace value

Signed-off-by: Fabio Kruger <[email protected]>

* Version bump

Signed-off-by: Fabio Kruger <[email protected]>

* Corrected typos

Signed-off-by: Fabio Kruger <[email protected]>

* Varsion bump

Signed-off-by: Fabio Kruger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants