-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[kube-prometheus-stack] Allow to set a timezone for the default grafana dashboards #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vsliouniaev
merged 14 commits into
prometheus-community:main
from
krufab:feature/timezone-fix
Sep 20, 2021
Merged
[kube-prometheus-stack] Allow to set a timezone for the default grafana dashboards #1326
vsliouniaev
merged 14 commits into
prometheus-community:main
from
krufab:feature/timezone-fix
Sep 20, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
vsliouniaev
reviewed
Sep 15, 2021
Signed-off-by: Fabio Kruger <[email protected]> # Conflicts: # charts/kube-prometheus-stack/Chart.yaml
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
vsliouniaev
previously approved these changes
Sep 17, 2021
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
Signed-off-by: Fabio Kruger <[email protected]>
vsliouniaev
previously approved these changes
Sep 20, 2021
Signed-off-by: Fabio Kruger <[email protected]>
vsliouniaev
approved these changes
Sep 20, 2021
QuentinBisson
pushed a commit
to giantswarm/prometheus-community-helm-charts-upstream
that referenced
this pull request
Oct 5, 2021
…na dashboards (prometheus-community#1326) * Allow to set a timezone for the default grafana dashboards Signed-off-by: Fabio Kruger <[email protected]> * Updated chart version Signed-off-by: Fabio Kruger <[email protected]> * prometheus-community#780 Improved regex Signed-off-by: Fabio Kruger <[email protected]> * prometheus-community#780 Improved regex Signed-off-by: Fabio Kruger <[email protected]> * prometheus-community#780 Improved regex Signed-off-by: Fabio Kruger <[email protected]> * prometheus-community#780 Improved regex Signed-off-by: Fabio Kruger <[email protected]> * prometheus-community#780 Improved regex Signed-off-by: Fabio Kruger <[email protected]> * Corrected typo in the regex replace value Signed-off-by: Fabio Kruger <[email protected]> * Version bump Signed-off-by: Fabio Kruger <[email protected]> * Corrected typos Signed-off-by: Fabio Kruger <[email protected]> * Varsion bump Signed-off-by: Fabio Kruger <[email protected]> Signed-off-by: QuentinBisson <[email protected]>
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…na dashboards (prometheus-community#1326) * Allow to set a timezone for the default grafana dashboards Signed-off-by: Fabio Kruger <[email protected]> * Updated chart version Signed-off-by: Fabio Kruger <[email protected]> * prometheus-community#780 Improved regex Signed-off-by: Fabio Kruger <[email protected]> * prometheus-community#780 Improved regex Signed-off-by: Fabio Kruger <[email protected]> * prometheus-community#780 Improved regex Signed-off-by: Fabio Kruger <[email protected]> * prometheus-community#780 Improved regex Signed-off-by: Fabio Kruger <[email protected]> * prometheus-community#780 Improved regex Signed-off-by: Fabio Kruger <[email protected]> * Corrected typo in the regex replace value Signed-off-by: Fabio Kruger <[email protected]> * Version bump Signed-off-by: Fabio Kruger <[email protected]> * Corrected typos Signed-off-by: Fabio Kruger <[email protected]> * Varsion bump Signed-off-by: Fabio Kruger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow to set a timezone for the default grafana dashboards.
The default dashboards have different timezones (utc, UTC, browser) and are loaded as read only in Grafana. Therefore, any change the user performs regarding the timezone, it cannot be saved.
This MR gives the user the possibility to set the some default timezone for all the dashboards (i.e. his / her own local timezone), without the need of modifying them.
Which issue this PR fixes
Fixes #780
Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter]
)Signed-off-by: Fabio Kruger [email protected]