Skip to content

[pull] master from primefaces:master #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 27, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 27, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Update issue templates and dependencies, improve Galleria and Tree components, and fix a bug in the Password component.

Bug Fixes:

  • Fix a bug where the Password component's value was not correctly bound.

Enhancements:

  • Improve the Galleria component by updating the logic for disabling navigation buttons.
  • Improve the Tree component by emitting the "filter" event on keyup instead of keydown and adding the filter value to the emitted event.
  • Update the Splitter component to handle panel sizes more effectively.

Tests:

  • Add tests for the Tree component's filter functionality.

@pull pull bot added the ⤵️ pull label Dec 27, 2024
Copy link

cr-gpt bot commented Dec 27, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@pull pull bot merged commit b76e39f into Abaso007:master Dec 27, 2024
Copy link

sourcery-ai bot commented Dec 27, 2024

Reviewer's Guide by Sourcery

This PR updates the issue template, updates dependencies, and fixes some bugs.

State diagram for issue labeling workflow

stateDiagram-v2
    [*] --> NeedsTriage: New Issue Created
    NeedsTriage --> NeedsMoreInfo: Missing Information
    NeedsTriage --> Available: Ready for Community
    NeedsTriage --> Duplicate: Similar Issue Exists
    NeedsMoreInfo --> NeedsTriage: Info Provided
    Available --> [*]: PR Merged
    Duplicate --> [*]: Issue Closed
Loading

File-Level Changes

Change Details Files
Updated the issue template with more comprehensive instructions and guidelines.
  • Added sections for providing a pull request link, reasons for not providing a PR, and environment details.
  • Included guidelines for creating a reproducer, specifying PrimeVue and Vue versions, and using StackBlitz.
  • Added a section for discussions and questions, directing users to GitHub Discussions or Discord.
  • Revised the overall structure and content of the template for improved clarity and guidance.
  • Updated labels and placeholder text for better user experience.
.github/ISSUE_TEMPLATE/bug_report.yml
Updated project dependencies.
  • Updated @nuxt/devtools to 0.8.5.
  • Updated consola to 3.3.3.
  • Updated es-module-lexer to 1.6.0.
  • Updated rollup-plugin-visualizer to 5.13.1.
  • Updated unstorage to 1.14.3.
pnpm-lock.yaml
Added a custom change event for InputOtp component.
  • Added InputOtpChangeEvent interface with originalEvent and value properties.
  • Updated change event in InputOtpEmitsOptions to use InputOtpChangeEvent.
packages/primevue/src/inputotp/InputOtp.d.ts
Fixed a bug in GalleriaThumbnails component where navigation buttons were not correctly disabled.
  • Removed unnecessary isNavBackwardDisabled() and isNavForwardDisabled() methods.
  • Added isNavBackwardDisabled and isNavForwardDisabled computed properties.
  • Updated navigation button styles to use the computed properties.
  • Added console logs for debugging purposes.
packages/primevue/src/galleria/GalleriaThumbnails.vue
packages/primevue/src/galleria/style/GalleriaStyle.js
Updated the issue-labeled workflow.
  • Updated the 'Issue Labeled' workflow to include a 'Duplicate' label check.
  • Added a step to close issues labeled as 'Duplicate' and add a comment indicating the duplication.
  • Modified the comment messages for 'Triage' and 'Help Wanted' labels.
.github/workflows/issue-labeled.yml
Fixed a bug in Tree component where filter was not working correctly.
  • Changed keydown event listener to keyup for filter input.
  • Added a test case to verify the filter functionality.
packages/primevue/src/tree/Tree.vue
packages/primevue/src/tree/Tree.spec.js
Fixed a bug in Splitter component where panel sizes were not being calculated correctly.
  • Used isNotEmpty utility function to check for non-empty panel sizes.
packages/primevue/src/splitter/Splitter.vue
Added count property to Timeline context.
  • Added count property to TimelineContext interface.
packages/primevue/src/timeline/Timeline.d.ts
Fixed a bug in Password component where the initial value was not being displayed correctly.
  • Changed value prop to defaultValue for the input element.
packages/primevue/src/password/Password.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants