Allow proper setting of `CI-RpaaSRPNotInPrivateRepo` #36405

scbedd · 2025-08-01T21:34:48Z

This is the plan. The necessary changes to remove processing of this value in impact.ts will come in a follow-up PR.

Instead we will check the outcome of this build (which WILL be eventually consistent because of the triggers) which will end up adding the CI-RpaaSRPNotInPrivateRepo in summarize-checks after confirming that the PR:

changes an RPaaS folder
targets main
includes resourcemanager label

Need to figure out a good way to test this new PR without merging it.

…aaSRPNotInPrivateRepo variable

openapi-pipeline-app · 2025-08-01T21:34:52Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2025-08-01T21:34:53Z

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

mikeharder · 2025-08-01T22:42:47Z

eng/pipelines/rpaas-private-check.yml

+  paths:
+    include:
+      # Trigger for files that will result in a specification change
+      - specification/**


Suggested change

- specification/**

- specification/**/resource-manager/**

Could we limit to only PRs impacting swaggers under the resource-manager folder?

mikeharder · 2025-08-01T22:43:02Z

eng/pipelines/rpaas-private-check.yml

+
+jobs:
+  - job: PresentInRPaaSCheck
+    name: Check RP Presenence in RPSaaSMaster


Suggested change

name: Check RP Presenence in RPSaaSMaster

name: Check RP Presence in RPSaaSMaster

mikeharder · 2025-08-01T22:44:47Z

.github/shared/cmd/detect-missing-rpaas-rp.js

Move to .github/workflows/cmd

mikeharder · 2025-08-01T22:45:26Z

.github/shared/cmd/detect-missing-rpaas-rp.js

+
+function usage() {
+  console.log(`Usage:
+npx api-doc-preview --output <output-dir>


Update to match new name and params

mikeharder · 2025-08-01T22:46:49Z

.github/shared/cmd/detect-missing-rpaas-rp.js

+  // Split the path and check if it starts with 'specification'
+  const pathParts = filePath.split('/');
+
+  if (pathParts.length >= 2 && pathParts[0] === 'specification') {


We know it must start with specification beacause of the filter you passed to getChangedFiles().

mikeharder · 2025-08-01T22:54:23Z

.github/shared/cmd/detect-missing-rpaas-rp.js

+// Check if reference directory exists
+try {
+  await access(referenceSpecPath);
+} catch (error) {
+  console.error(`Reference specification directory does not exist: ${referenceSpecPath}`);
+  process.exit(1);
+}


Suggested change

// Check if reference directory exists

try {

await access(referenceSpecPath);

} catch (error) {

console.error(`Reference specification directory does not exist: ${referenceSpecPath}`);

process.exit(1);

}

should be sufficient to let FS error bubble and fail app

mikeharder · 2025-08-01T22:56:59Z

.github/shared/cmd/detect-missing-rpaas-rp.js

+  const items = await readdir(referenceSpecPath);
+
+  // Filter to only directories
+  referenceRpFolders = [];
+  for (const item of items) {
+    const itemPath = join(referenceSpecPath, item);
+    try {
+      const stats = await stat(itemPath);
+      if (stats.isDirectory()) {
+        referenceRpFolders.push(item);
+      }
+    } catch (statError) {
+      // Skip items we can't stat (permissions, etc.)
+      console.warn(`Warning: Could not stat ${itemPath}:`, statError.message);
+    }
+  }


Suggested change

const items = await readdir(referenceSpecPath);

// Filter to only directories

referenceRpFolders = [];

for (const item of items) {

const itemPath = join(referenceSpecPath, item);

try {

const stats = await stat(itemPath);

if (stats.isDirectory()) {

referenceRpFolders.push(item);

}

} catch (statError) {

// Skip items we can't stat (permissions, etc.)

console.warn(`Warning: Could not stat ${itemPath}:`, statError.message);

}

}

const items = await readdir(referenceSpecPath, {withFileTypes:true}).filter(d => d.isDirectory()).map(d => d.name);

referenceRpFolders = new Set(items);

mikeharder · 2025-08-01T22:57:30Z

.github/shared/cmd/detect-missing-rpaas-rp.js

+} catch (error) {
+  console.error(`Error reading reference directory ${referenceSpecPath}:`, error.message);
+  process.exit(1);
+}


Suggested change

} catch (error) {

console.error(`Error reading reference directory ${referenceSpecPath}:`, error.message);

process.exit(1);

}

} catch (error) {

console.error(`Error reading reference directory ${referenceSpecPath}:`, error.message);

process.exit(1);

}

sufficient to let exception bubble

mikeharder · 2025-08-01T23:00:03Z

.github/workflows/rpaas-private-check-status.yml

I was going to ask if this should be a separate WF, or part of summarize-checks? But it looks like summarize_checks only triggers on WF run, not check run, and we probably don't want to change that? So we need an intermediate WF to bridge the gap with devops?

mikeharder · 2025-08-01T23:01:40Z

.github/workflows/summarize-checks.yaml

@@ -55,8 +56,8 @@ jobs:
        uses: actions/github-script@v7
        with:
          script: |
-            const { default: dumpTriggerMetadata } =
-              await import('${{ github.workspace }}/.github/workflows/src/summarize-checks/dump-trigger-metadata.js');
+            const { extractInputs } =


mikeharder · 2025-08-01T23:04:40Z

.github/shared/cmd/detect-missing-rpaas-rp.js

I'd like to use consistent names for all 3 related files in this check. How about "RPaaS Branch Validation"?

mikeharder · 2025-08-01T23:08:31Z

.github/workflows/rpaas-private-check-status.yml

+      - name: "Get Issue Number"
+        id: get-issue-number
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const { extractInputs } =
+              await import('${{ github.workspace }}/.github/workflows/src/context.js');
+
+            const { issue_number } = await extractInputs({ github, context, core });
+            core.setOutput("issue_number", issue_number);


I will move this to a shared GH Action after you merge.

mikeharder

see comments

mikeharder · 2025-08-01T23:14:37Z

eng/pipelines/rpaas-private-check.yml

+      - template: /eng/pipelines/templates/steps/npm-install.yml
+        parameters:
+          WorkingDirectory: .github/shared


Suggested change

- template: /eng/pipelines/templates/steps/npm-install.yml

parameters:

WorkingDirectory: .github/shared

- template: /eng/pipelines/templates/steps/npm-install.yml

parameters:

WorkingDirectory: .github

We could improve perf with a custom install command if needed (npm ci --no-audit --omit dev);. But this might be good enough for a devops pipeline.

mikeharder · 2025-08-01T23:16:42Z

.github/shared/cmd/detect-missing-rpaas-rp.js

Please add tests. Refactor into exported functions if it helps.

adding new pipeline that will allow us to intelligently set the CI-Rp…

fcc8fa5

…aaSRPNotInPrivateRepo variable

scbedd requested review from weshaggard, mikeharder and benbp as code owners August 1, 2025 21:34

scbedd self-assigned this Aug 1, 2025

scbedd added this to Azure SDK EngSys 🍕 Aug 1, 2025

github-project-automation bot moved this to 🤔 Triage in Azure SDK EngSys 🍕 Aug 1, 2025

mikeharder reviewed Aug 1, 2025

View reviewed changes

.github/shared/cmd/detect-missing-rpaas-rp.js

Copy link

Member

mikeharder Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to .github/workflows/cmd

mikeharder reviewed Aug 1, 2025

View reviewed changes

mikeharder requested changes Aug 1, 2025

View reviewed changes

mikeharder reviewed Aug 1, 2025

View reviewed changes

.github/shared/cmd/detect-missing-rpaas-rp.js

Copy link

Member

mikeharder Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests. Refactor into exported functions if it helps.

	name: Check RP Presenence in RPSaaSMaster
	name: Check RP Presence in RPSaaSMaster

Allow proper setting of CI-RpaaSRPNotInPrivateRepo #36405

Are you sure you want to change the base?

Allow proper setting of CI-RpaaSRPNotInPrivateRepo #36405

Uh oh!

Conversation

scbedd commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-pipeline-app bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Aug 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikeharder Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikeharder left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Allow proper setting of `CI-RpaaSRPNotInPrivateRepo` #36405

Allow proper setting of `CI-RpaaSRPNotInPrivateRepo` #36405

scbedd commented Aug 1, 2025 •

edited

Loading

openapi-pipeline-app bot commented Aug 1, 2025 •

edited

Loading

mikeharder Aug 1, 2025 •

edited

Loading