Swerc suggestions #32
Conversation
We typicly later branch from main to a dedicated branch but this should work most of the time.
There is a correlation between the restricted network and dedicated git repo this makes this very explicit.
| @@ -38,6 +38,7 @@ PHP_MAX_FILE_UPLOADS: 101 | |||
| # Git repo URL | |||
| DJ_GIT_HOST: "{{MAIN_ADMIN_IP}}" | |||
| DJ_GIT_REPO: "domjudge@{{DJ_GIT_HOST}}:domjudge" | |||
| DJ_GIT_REPO_UPSTREAM: "https://github.com/domjudge/domjudge.git" | |||
| DJ_GIT_REPO_SCRIPTS: "domjudge@{{DJ_GIT_HOST}}:domjudge-scripts-bare" | |||
There was a problem hiding this comment.
Do we need a similar thing for this repo?
There was a problem hiding this comment.
I think it makes more sense to set the DJ_GIT_REPO variable correctly depending on context, instead of duplicating the create working copy of the domjudge repo task below.
There was a problem hiding this comment.
For the SCRIPTS? That probably relevant if we would have admin machines.,
I think we'll never use it but yes, I'll add it.
There was a problem hiding this comment.
And I agree with Jaap, just for fixing the script this was the quickest fix.
| @@ -38,6 +38,7 @@ PHP_MAX_FILE_UPLOADS: 101 | |||
| # Git repo URL | |||
| DJ_GIT_HOST: "{{MAIN_ADMIN_IP}}" | |||
| DJ_GIT_REPO: "domjudge@{{DJ_GIT_HOST}}:domjudge" | |||
| DJ_GIT_REPO_UPSTREAM: "https://github.com/domjudge/domjudge.git" | |||
| DJ_GIT_REPO_SCRIPTS: "domjudge@{{DJ_GIT_HOST}}:domjudge-scripts-bare" | |||
There was a problem hiding this comment.
I think it makes more sense to set the DJ_GIT_REPO variable correctly depending on context, instead of duplicating the create working copy of the domjudge repo task below.
| @@ -93,6 +93,17 @@ | |||
| - tig | |||
There was a problem hiding this comment.
Also need to fix the composer as we need the "hip" one which I now locally installed.
Lets first agree on which ones we want to keep and afterwards I can make the message useful.