merge #1
Merged
merge #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to `await` a call to `require`, and they might sooner be written in single lines to mimic the style used for the previous examples.
fix async/await example
* Simplify "Use searchable names" example There is no need to create an arrow function to execute a function inside of the timeout. * Remove `this` to avoid context problems
Modify open/closed principle
fix some code style nits in examples
remove duplicate word in 'Remove duplicate code' :)
fix is-a order in Prefer composition over inheritance description
Add Side Effects pt.2
`cart` is an Array. the ES6 spread operator can be used : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator
Immutable error
fix confusing example
Add translation section same format AirBnb style, with Brazilian Portuguese and Chinese translations
Change literal for a constant
Changed Function arguments section to include destructuring
Fix method call in getter/setter example
**Pedal** is the act of using bicycle pedals. *Peddle* means to travel around selling something. I think you meant the former. BTW, thanks for the great guide!
Add russian translation
README.md: change 'peddle' to 'pedal'
Maker function instead of Function constructor
Update the example from "Single concept per test"
* Explicitly describing a function #175 * Keeping consistency by using singular nouns
Liskov Substitution (SOLID section) - width/height/length as constructor params
getters and setters as functions, also without the get/set keywords
Fixes some typo issues
Add vietnamese translation
Adds second Russian translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.