Skip to content

Added sorting algorithm to Sorts folder #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Addypillar
Copy link

@Addypillar Addypillar commented Oct 4, 2023

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Addypillar
Copy link
Author

Added Sorting Algorithm

@Addypillar Addypillar closed this Oct 4, 2023
@Addypillar Addypillar reopened this Oct 4, 2023
@appgurueu
Copy link
Collaborator

  • This is not a "sorting" algorithm. What this does is called shuffling, and we already have Fisher-Yates for that.
  • Unlike Fisher-Yates, this is not O(n); since splicing is a linear time operation, this is really O(n²), so needlessly inefficient.
  • Code-wise, this consumes the array passed into it despite building a new array. This is calling for trouble. It also contains an example using console.log - unexpected side effects - rather than proper tests.
  • This is missing basic documentation and testing.

All in all, I'm afraid I don't think this PR is a good fit for the repo. In the future, try to check whether we already have an algorithm solving the problem, and don't forget to add documentation and tests.

@appgurueu appgurueu closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants