update #1
Merged
update #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turing Replace map method with object destructuring
There's -> There are
minor grammar edit
Update README.md
It doesn't need to be a global constant. JavaScript constants are block-scoped.
Fix "Use searchable names" section
Fix "Use searchable names" section
Change complex reduce code sample to clearer map reduce.
…iting or conditionals". Did not adhere to "Don't add unneeded context".
Change argument name of "Use default arguments instead of short circu…
…bstraction* Like said in https://github.com/ryanmcdermott/clean-code-javascript#function-callers-and-callees-should-be-close, the code is read from top to bottom, so I'd prefer the definition of the *function parseBetterJSAlternative* above the functions called within.
Changing order in example of *Functions should only be one level …*
there are `nodeAdapter`, no `httpNodeAdapter`
- rename ast variable to be more explicit (see, Avoid Mental Mapping) - rename function lexer to include a verb in it's name (see, https://herbertograca.com/2016/09/03/clean-code-3-functions-by-robert-c-martin-uncle-bob/) - from my understanding, the term lexer is usally used for the process of building a stream of tokens. So lexer and tokenize are different names for the same thing
Fixed a small typo
This reverts commit 2edfeef.
Turkish added
Ukrainian translation is added
Fix calling animationModule in ISP bad example
Change argument name from inner variable name
This edit only affects the Avoid Side Effects (part 2) section. It replaces the discussion of pass by reference with an explanation in terms of mutability. By avoiding the confusing terminology and possible links to the implementation details of different JS engines the explanation can be kept at an abstraction level that's great for beginners and experts alike. I also cleaned up some grammar, typos, etc.
…rence Replace pass-by-reference with mutability, clean up
Add calculation for milliseconds in a day
…rence Fix stray hyphen turning into a random bullet
Add Serbian translation.
"PER" has the same meaning as "IN_A" but is less verbose
Make example more succinct
Fix wrong naming of `default parameters`
French translation
Persian translation added (Fluent + RTL styled)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.