Fix test for invariant culture parsing #62631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the `DecimalWithRange` property in the `ComplexTypeWithParsableProperties` class to include the `ParseLimitsInInvariantCulture` attribute in the `Range` attribute. This change ensures consistent parsing of range limits across different locale settings.
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
martincostello
added
area-minimal
captainsafia
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
DecimalWithRangeproperty in theCanValidateTypeWithParsablePropertiestest of the ValidationsGenerator.Parsable.cs class to include theParseLimitsInInvariantCulturesetting within theRangeattribute. This change ensures consistent parsing of range limits across different locale settings. On my machine (which uses the it-IT culture), the original test failed due to a conversion issue.Fixes #62627