#62774 Fix JWT Bearer unit tests failing if local timezone is UTC+N #62775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TC+N Tests were failing if local timezone is to the east of UTC, due to DateTime.MaxValue is locale-specific. Add explicit DateTimeKind UTC and immediate conversion to UTC when parsing, since this time is unrepresentable in local timezone
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
area-auth
There was a problem hiding this comment.
Pull Request Overview
This PR fixes JWT Bearer unit tests that were failing when run in timezones east of UTC (UTC+N). The issue occurred because DateTime.MaxValue is locale-specific, causing test failures in certain timezone configurations.
Key changes:
- Explicitly set
DateTimeKind.Utcwhen creating JWT tokens withDateTime.MaxValueexpiration - Simplified DateTime parsing to directly convert to UTC using
DateTimeStyles.AdjustToUniversal
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Security/Authentication/test/JwtBearerTests_Handler.cs | Updated JWT token creation and DateTime parsing to use explicit UTC handling |
| src/Security/Authentication/test/JwtBearerTests.cs | Applied identical fixes for JWT token creation and DateTime parsing consistency |
This was referenced Jul 17, 2025
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing if local timezone is to the east of UTC, due to
DateTime.MaxValueis locale-specific. Add explicitDateTimeKindUTC and immediate conversion to UTC when parsing, since this time is unrepresentable in local timezoneFixes #62774