[release/9.0] [SignalR] Don't throw for message headers in Java client #62783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
BrennanConroy and
halter73
as code owners
dotnet-policy-service
bot
added
the
pending-ci-rerun
BrennanConroy
added
the
Servicing-consider
|
Hi @@github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62739 to release/9.0
/cc @BrennanConroy
[SignalR] Don't throw for message headers in Java client
Description
If a Java client connects to a SignalR server that is writing "headers" (SignalR protocol concept), then the connection will close with an error.
This happened when Azure SignalR Service (ASRS) added some distributed tracing information to messages and broke a bunch of customer apps. The change has since been reverted by ASRS, but we would like to fix the Java clients to allow this feature to be readded in the future.
Fixes #62713
Customer Impact
Customer client apps broken by server upgrade. Issue linked above shows many customers hit by this.
Regression?
Risk
Unused code currently. In the future it may be used, and it's fairly simple code with a couple tests added for it.
Verification
Packaging changes reviewed?