Follow-up on IsLocalhost TLD local dev #62838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-networking
dotnet-policy-service
bot
added
the
community-contribution
Changed `IsLocalhost` from an instance method to a static method. Updated the parameter to use `host` directly instead of `parsedAddress.Host`. Modified the check for the `.localhost` TLD to ensure the host length is greater than 10, optimizing the condition to avoid unnecessary checks for shorter hostnames. Fixes dotnet#61155
ladeak
commented
Jul 21, 2025
BrennanConroy
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsLocalhost TLD optimization
IsLocalhost avoids capturing closure. Follow up on comment #62593 (comment)
Description
Changed
IsLocalhostfrom an instance method to a static method. Updated the parameter to usehostdirectly instead ofparsedAddress.Host. Modified the check for the.localhostTLD to ensure the host length is greater than 10, optimizing the condition to avoid unnecessary checks for shorter hostnames.It also avoids an additional string comparison, slightly improving the performance (both optimized and non-optimized (
[MethodImpl(MethodImplOptions.NoOptimization)]cases), given this code is likely to run a lot with Debug builds.Fixes #62592