Stop using outdated 5.0 sdk image in wasm benchmarks #62884
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the .NET SDK version in the WASM performance benchmarks Docker configuration from the outdated 5.0 version to the latest available version. This ensures the benchmarks use current tooling and runtime capabilities.
- Updates Docker base image from .NET SDK 5.0 to latest version
| @@ -1,4 +1,4 @@ | |||
| FROM mcr.microsoft.com/dotnet/sdk:5.0 AS build | |||
| FROM mcr.microsoft.com/dotnet/sdk:latest AS build | |||
There was a problem hiding this comment.
Using 'latest' tag in Docker images can lead to unpredictable builds and compatibility issues. Consider pinning to a specific version like 'mcr.microsoft.com/dotnet/sdk:9.0' to ensure reproducible builds.
| FROM mcr.microsoft.com/dotnet/sdk:latest AS build | |
| FROM mcr.microsoft.com/dotnet/sdk:9.0 AS build |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
We're fine with that risk since we don't use the dotnet from the system anyway. Otherwise we'll just forget to bump this again in 2+ years.
There was a problem hiding this comment.
my only concern with latest is not seeing the image change in the diff when it happens but I'm fine with taking this and discussing options
There was a problem hiding this comment.
yeah it should be pretty obvious since it'd happen right around 10.0 GA.
apart from that the OS version is also not set in stone for the tags either, we'd need to use a specific 9.0-bookworm tag
| @@ -1,4 +1,4 @@ | |||
| FROM mcr.microsoft.com/dotnet/sdk:5.0 AS build | |||
| FROM mcr.microsoft.com/dotnet/sdk:latest AS build | |||
There was a problem hiding this comment.
my only concern with latest is not seeing the image change in the diff when it happens but I'm fine with taking this and discussing options
The 5.0 image can't reach Debian apt repos anymore.