Quarantine OpenApiDocumentLocalizationTests.VerifyOpenApiDocumentIsInvariant #63074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OpenApiDocumentIsInvariant Co-authored-by: captainsafia <[email protected]>
…variant Co-authored-by: captainsafia <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
captainsafia
August 3, 2025 01:18
captainsafia
approved these changes
Aug 3, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR quarantines a failing test VerifyOpenApiDocumentIsInvariant to prevent it from blocking builds while a proper fix is being developed. The test has been experiencing failures due to mismatched OpenAPI document JSON output compared to expected snapshots.
- Adds
[QuarantinedTest]attribute to the failing test with a reference to tracking issue #63073 - Maintains test visibility and execution while preventing build failures
- Follows established repository patterns for handling temporarily failing tests
|
#63077 should fix this without the need to quarantine. |
JamesNK
approved these changes
Aug 3, 2025
Policy is we quarantine then check to ensure the test is reliably fixed 30 days later. |
|
It was just an issue caused by a PR changing the same file not being up to the subsequently merged PR, it was broken not flakey. The referenced PR fixes the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
OpenApiDocumentLocalizationTests.VerifyOpenApiDocumentIsInvarianthas been failing due to a mismatch between the received and verified OpenAPI document JSON output. This test uses the Verify framework to ensure the localized OpenAPI document output remains consistent, but recent changes have caused the output to differ from the expected snapshot.To prevent this failing test from blocking builds while a proper fix is being developed, this PR quarantines the test by adding the
[QuarantinedTest]attribute with a reference to the tracking issue.The quarantined test will:
Quarantined=truetrait for filteringThis approach follows the established pattern in the repository for handling flaky or temporarily failing tests while preserving test visibility and allowing proper investigation and resolution.
Fixes #63073.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.