[Blazor] Fix HotReloadManager accessibility in Server project by including shared source #63287

Copilot · 2025-08-15T21:10:19Z

This PR fixes the HotReloadManager accessibility error in the Server project that was preventing compilation. The issue occurred because HotReloadManager is marked as internal in the Components.Shared assembly and wasn't accessible from the Components.Server assembly.

Root Cause

The original implementation attempted to use HotReloadManager.Default directly in the Server project:

// In ServerComponentDeserializer.cs - Server project
static ServerComponentDeserializer()
{
    if (HotReloadManager.Default.MetadataUpdateSupported)  // CS0122 error
    {
        HotReloadManager.Default.OnDeltaApplied += _rootTypeCache.Clear;
    }
}

This caused compilation errors:

CS0122: 'HotReloadManager' is inaccessible due to its protection level

Solution

Added HotReloadManager.cs as a linked source file to the Server project in Microsoft.AspNetCore.Components.Server.csproj:

<Compile Include="$(ComponentsSharedSourceRoot)src\HotReloadManager.cs" LinkBase="HotReload" />

This makes HotReloadManager accessible within the Server assembly, allowing static RootTypeCache instances to register for hot reload directly in static constructors where they're defined.

Changes Made

Microsoft.AspNetCore.Components.Server.csproj:

Added HotReloadManager.cs as linked source file

ServerComponentDeserializer:

Added static constructor with hot reload registration for static _rootTypeCache field
Restored using directive for Microsoft.AspNetCore.Components.HotReload

ComponentServiceCollectionExtensions:

Restored hot reload registration in RegisterForHotReload method
Added using directive for HotReloadManager

Benefits

Fixes compilation errors: Resolves CS0122 accessibility errors
Maintains static field pattern: Keeps static RootTypeCache fields with proper hot reload support
Follows established patterns: Same approach used by Components project which already includes HotReloadManager
No runtime behavior changes: Only enables hot reload cache clearing that was intended in the original design

The implementation maintains the same functionality while ensuring the code compiles successfully across all target projects.

Fixes #63286.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: javiercn <[email protected]>

javiercn · 2025-08-15T21:30:23Z

src/Components/Components/test/RootTypeCacheTest.cs

@copilot remove this file.

Removed the test file as requested in commit 62e8bab.

javiercn · 2025-08-15T21:30:48Z

src/Components/Shared/src/RootTypeCache.cs

+    public RootTypeCache()
+    {
+        lock (_instances)
+        {
+            _instances.Add(new WeakReference(this));
+        }
+    }


Suggested change

public RootTypeCache()

{

lock (_instances)

{

_instances.Add(new WeakReference(this));

}

}

Co-authored-by: javiercn <[email protected]>

javiercn · 2025-08-15T21:43:32Z

src/Components/Shared/src/RootTypeCache.cs

+        }
+    }
+#endif
+


@copilot

Don't do #if COMPONENTS. Add an internal instance method Clear to clear the concurrent dictionary cache. Look for all the callsites where the RootTypeCache is used, and add the MetadataUpdateHandler in those situations.

You can set things up in the constructor since those types are Singletons.

aspnetcore/src/Components/Server/src/Circuits/ServerComponentDeserializer.cs

Line 62 in 52453ff

private readonly RootTypeCache _RootTypeCache;

Look for places where you can make private RootTypeCache fields static if they aren't. Like

aspnetcore/src/Components/Server/src/Circuits/ServerComponentDeserializer.cs

Line 62 in 52453ff

private readonly RootTypeCache _RootTypeCache;

@copilot

I've implemented the requested changes. Removed #if COMPONENTS directives, added an internal Clear() method to RootTypeCache, and registered MetadataUpdateHandler at the singleton registration points in ComponentServiceCollectionExtensions and PersistentServicesRegistry. WebAssembly project builds without hot reload support as expected since it doesn't include HotReloadManager.

I've implemented the requested changes:

Made ServerComponentDeserializer._RootTypeCache field static and added hot reload support in static constructor (b2d6288)

Made DefaultWebAssemblyJSRuntime._rootComponentCache field static (WebAssembly doesn't include HotReloadManager so no hot reload registration)

Updated constructor signatures and test files to remove RootTypeCache parameters where they're now static

Updated usages to reference the static fields instead of instance fields

The implementation follows the same pattern used by PersistentServicesRegistry which already has a static _persistentServiceTypeCache with hot reload support in its static constructor.

Co-authored-by: javiercn <[email protected]>

…uctors Co-authored-by: javiercn <[email protected]>

…eters Co-authored-by: javiercn <[email protected]>

javiercn · 2025-08-16T11:18:34Z

@copilot

rc\Components\Server\src\DependencyInjection\ComponentServiceCollectionExtensions.cs(135,13): error CS0122: 'HotReloadManager' is inaccessible due to its protection level
❌src\Components\Server\src\DependencyInjection\ComponentServiceCollectionExtensions.cs(137,13): error CS0122: 'HotReloadManager' is inaccessible due to its protection level
❌src\Components\Server\src\Circuits\ServerComponentDeserializer.cs(68,13): error CS0122: 'HotReloadManager' is inaccessible due to its protection level

javiercn · 2025-08-16T11:20:25Z

src/Components/Shared/src/RootTypeCache.cs

-#if COMPONENTS
-namespace Microsoft.AspNetCore.Components.Infrastructure;
-#else
 namespace Microsoft.AspNetCore.Components;
-#endif


@copilot undo this change

Reverted the namespace declaration back to block-scoped format as requested (commit 993ba49).

…red source Co-authored-by: javiercn <[email protected]>

Copilot · 2025-08-16T11:34:44Z

@copilot

rc\Components\Server\src\DependencyInjection\ComponentServiceCollectionExtensions.cs(135,13): error CS0122: 'HotReloadManager' is inaccessible due to its protection level
...

Fixed the HotReloadManager accessibility error by including HotReloadManager.cs as a linked source file in the Server project. The error occurred because HotReloadManager is marked internal and was only available in the Components assembly. Added the shared source file to enable hot reload registration directly in static constructors where the static RootTypeCache fields are defined (commit 2859f25).

Co-authored-by: javiercn <[email protected]>

javiercn · 2025-08-16T13:58:15Z

@copilot

src\Components\Shared\src\RootTypeCache.cs(8,1): error IDE0161: Convert to file-scoped namespace (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0161)
aspnetcore-ci / Build / Build: Windows x64/x86/arm64 / Build x64
[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
❌src\Components\Shared\src\RootTypeCache.cs(8,1): error IDE0161: Convert to file-scoped namespace (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0161)
aspnetcore-ci / Build / Build: macOS arm64 / Run build.sh
[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
❌src/Components/Shared/src/RootTypeCache.cs(8,1): error IDE0161: Convert to file-scoped namespace (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0161)

Co-authored-by: javiercn <[email protected]>

Copilot · 2025-08-16T14:06:37Z

@copilot

src\Components\Shared\src\RootTypeCache.cs(8,1): error IDE0161: Convert to file-scoped namespace (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0161)
...

Converted the namespace to file-scoped format to fix the IDE0161 linting error (commit c74ec0f).

Initial plan

9f7175f

Copilot AI assigned Copilot and javiercn Aug 15, 2025

Copilot started work on behalf of javiercn August 15, 2025 21:10 View session

dotnet-policy-service bot added the Attention: Shared Code Modified label Aug 15, 2025

Implement hot reload cache clearing for RootTypeCache

941dcd7

Co-authored-by: javiercn <[email protected]>

javiercn reviewed Aug 15, 2025

View reviewed changes

Fix conditional compilation for RootTypeCache hot reload support

af5307b

Co-authored-by: javiercn <[email protected]>

Copilot AI changed the title ~~[WIP] [Blazor] Missing cache clear on hot reload~~ [Blazor] Add missing cache clear on hot reload for RootTypeCache Aug 15, 2025

Copilot AI requested a review from javiercn August 15, 2025 21:35

Copilot finished work on behalf of javiercn August 15, 2025 21:35

Copilot started work on behalf of javiercn August 15, 2025 21:35 View session

Remove RootTypeCacheTest.cs as requested

62e8bab

Co-authored-by: javiercn <[email protected]>

javiercn reviewed Aug 15, 2025

View reviewed changes

Copilot AI requested a review from javiercn August 15, 2025 21:44

Copilot finished work on behalf of javiercn August 15, 2025 21:44

Copilot started work on behalf of javiercn August 15, 2025 21:44 View session

Refactor RootTypeCache hot reload to use instance Clear method

562666c

Co-authored-by: javiercn <[email protected]>

Copilot finished work on behalf of javiercn August 15, 2025 22:05

Copilot started work on behalf of javiercn August 15, 2025 22:05 View session

Copilot AI and others added 2 commits August 15, 2025 22:22

Make RootTypeCache fields static and add hot reload support in constr…

b2d6288

…uctors Co-authored-by: javiercn <[email protected]>

Update remaining test files to remove RootTypeCache constructor param…

9916739

…eters Co-authored-by: javiercn <[email protected]>

Copilot AI changed the title ~~[Blazor] Add missing cache clear on hot reload for RootTypeCache~~ [Blazor] Refactor RootTypeCache to use static fields with hot reload support Aug 15, 2025

Copilot finished work on behalf of javiercn August 15, 2025 22:29

Copilot started work on behalf of javiercn August 16, 2025 11:18 View session

javiercn reviewed Aug 16, 2025

View reviewed changes

Fix HotReloadManager accessibility in Server project by including sha…

2859f25

…red source Co-authored-by: javiercn <[email protected]>

Copilot AI changed the title ~~[Blazor] Refactor RootTypeCache to use static fields with hot reload support~~ [Blazor] Fix HotReloadManager accessibility in Server project by including shared source Aug 16, 2025

Copilot finished work on behalf of javiercn August 16, 2025 11:36

Copilot AI requested a review from javiercn August 16, 2025 11:36

Copilot started work on behalf of javiercn August 16, 2025 11:36 View session

Revert to block-scoped namespace as requested

993ba49

Co-authored-by: javiercn <[email protected]>

Copilot finished work on behalf of javiercn August 16, 2025 11:45

Copilot started work on behalf of javiercn August 16, 2025 13:58 View session

Convert RootTypeCache namespace to file-scoped format

c74ec0f

Co-authored-by: javiercn <[email protected]>

Copilot finished work on behalf of javiercn August 16, 2025 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Blazor] Fix HotReloadManager accessibility in Server project by including shared source #63287

[Blazor] Fix HotReloadManager accessibility in Server project by including shared source #63287

Copilot AI commented Aug 15, 2025 •

edited

Loading

Uh oh!

javiercn Aug 15, 2025

Uh oh!

Copilot AI Aug 15, 2025

Uh oh!

javiercn Aug 15, 2025

Uh oh!

javiercn Aug 15, 2025

Uh oh!

javiercn Aug 15, 2025

Uh oh!

Copilot AI Aug 15, 2025

Uh oh!

Copilot AI Aug 15, 2025

Uh oh!

javiercn commented Aug 16, 2025

Uh oh!

javiercn Aug 16, 2025

Uh oh!

Copilot AI Aug 16, 2025

Uh oh!

Copilot AI commented Aug 16, 2025

Uh oh!

javiercn commented Aug 16, 2025

Uh oh!

Copilot AI commented Aug 16, 2025

Uh oh!

Uh oh!

[Blazor] Fix HotReloadManager accessibility in Server project by including shared source #63287

Are you sure you want to change the base?

[Blazor] Fix HotReloadManager accessibility in Server project by including shared source #63287

Conversation

Copilot AI commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root Cause

Solution

Changes Made

Benefits

Uh oh!

javiercn Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

javiercn Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

javiercn Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

javiercn Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

javiercn commented Aug 16, 2025

Uh oh!

javiercn Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Aug 16, 2025

Uh oh!

javiercn commented Aug 16, 2025

Uh oh!

Copilot AI commented Aug 16, 2025

Uh oh!

Uh oh!

Copilot AI commented Aug 15, 2025 •

edited

Loading