Add warnings and guidance against using volatile keyword #47282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot stopped work on behalf of
BillWagner due to an error
July 10, 2025 13:57
dotnet-policy-service
bot
added
the
okr-quality
|
@copilot Can you start working on this again? |
Co-authored-by: BillWagner <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
BillWagner
July 10, 2025 20:38
BillWagner
reviewed
Jul 14, 2025
There was a problem hiding this comment.
Great start @copilot
I've got one comment for you to address.
Co-authored-by: BillWagner <[email protected]>
Copilot finished work on behalf of
BillWagner
July 14, 2025 17:55
BillWagner
approved these changes
Jul 14, 2025
IEvangelist
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23832
The
volatilekeyword documentation now includes prominent warnings about its limitations and strongly recommends safer alternatives for multithreaded programming.Changes Made
volatileearly in the documentSystem.Threading.Interlockedoperations for atomic operationslockstatements for mutual exclusionSystem.Threading.Volatileclass for explicit volatile operationsWhy These Changes
The C# community has identified that
volatileis often misunderstood and misused, leading to subtle concurrency bugs. The existing documentation provided technical information but lacked guidance about when not to usevolatileand what to use instead.What This Addresses
volatilevolatiledoesn't provide atomicity, prevent race conditions, or guarantee memory orderingvolatileThe documentation now follows the community consensus that
volatileshould be avoided in favor of more reliable alternatives while still providing the technical details for advanced scenarios.💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
Internal previews