Merge forked repo #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to `await` a call to `require`, and they might sooner be written in single lines to mimic the style used for the previous examples.
fix async/await example
* Simplify "Use searchable names" example There is no need to create an arrow function to execute a function inside of the timeout. * Remove `this` to avoid context problems
Modify open/closed principle
fix some code style nits in examples
remove duplicate word in 'Remove duplicate code' :)
fix is-a order in Prefer composition over inheritance description
Add Side Effects pt.2
`cart` is an Array. the ES6 spread operator can be used : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator
Immutable error
fix confusing example
Add translation section same format AirBnb style, with Brazilian Portuguese and Chinese translations
In the Bad section, shouldn't it be config.cancellable !== undefined?
Mistake in the Set default objects with Object.assign
Add Japanese translation
updating L278 to `isActiveClient`
...you will find that those *case*... -> ..you will find that those *cases*...
fixed a grammatical typo
Fix duplicate code example
Update README.md to include explanatory function names per #200
Add Polish translation
* translate kata pengantar / introduction * translate variabel * typo * function 1/2 * 1/2 replace * translate ### 😂 * translate Function section in Bahasa Indonesia is done * 1/2 SOLID translation to Bahasa Indonesia * SOLID translation to Bahasa Indonesia is Done * translating Error Handling to bahasa indonesia is done * well done, translated to Bahasa Indonesia * review 1, check typo * review 2 * just link
Capital letters in const, remove default data in class Car
Capital letters in const, remove default data in class Car
The proposed "good" way of coding was actually changing a property's name in the developers object. While one can argue that in this case they could be the same, the point of the example was to show that you can still remove duplicated code that require *different* things.
Fixed duplicate code
Remove space before colon in object.
Object style consistency
Update README.md
'data' is never reassigned. Use 'const' instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.