tool: tinker: try to nudge away from creating test users ahead of time #108
+6
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for a future test
…e for a future test
All of boost doesn't run in a non-local environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Povilas reported feedback about Junie creating 5 test users via tinker, then writing a test to verify it could see the user's in the Filament (I think) table.
Of course, the test should create the users, we don't want our DB polluted with random unrequested users.
I then experienced. a similar thing when adding a feature to the Boost Documentation API. I couldn't remember how to setup a user to login to Nova, so I asked it, then it created a brand new user using tinker, without the correct role, when we had a perfectly good artisan commands for it.
This tool description change helps with some of this