refactor: replace ApplicationDetector with CodeEnvironementsDetector in InstallCommand and update related methods #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in InstallCommand and update related methods
…mmand for consistency
…e environments in InstallCommand for clarity
…Environment contract
…ectDetectionConfig key from 'types' to 'type'
… adjust related detection methods
…o infer types from config
…in DetectionStrategyFactory
…odeEnvironment class
…e related methods; add CodeEnvironmentsDetector class with detection logic and tests
…ed tests for improved detection accuracy
pushpak1300
force-pushed
the
cleanup_application_detector
branch
from
218ddc5 to
43da069
Compare
pushpak1300
force-pushed
the
cleanup_application_detector
branch
from
43da069 to
7fcdf31
Compare
Refactor InstallCommand for clarity and maintainability
|
Going to merge this - as part of https://linear.app/laravel/issue/AI-53/cleaner-agentide-management-in-installcommand-pair we'll want to figure out how to identify a code environment as agent, ide, or both Then I guess merge the existing agents/IDEs into code environments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR refactors the Application detector logic in a modular way.