Refactor SearchDocs tests to use Http facade #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date request verification logic - Added `guzzlehttp/guzzle` as a dependency in `composer.json`. - Updated `MakesHttpRequests` to support `testing` environment for SSL verification. - Simplified and modernized tests with `Http::fake` and `Http::assertSent`.
|
Is guzzle a dependency? I thought Http found any compatible PSR-7 client? Trying to keep the boost dependencies really small, so want to be 100% certain here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the
SearchDocstests by replacingMockerywith Laravel'sHttpfacade for a cleaner and more maintainable approach. Key changes include:MockerywithHttp::fakeandHttp::assertSent.MakesHttpRequeststo support thetestingenvironment with proper SSL verification handling.guzzlehttp/guzzleas a dependency incomposer.json.These updates simplify the test logic and modernize the approach for handling HTTP requests in tests.