Refactor browser logging methods to static

[inxilpro]

This PR fixes #37

Right now mapJsTypeToPsr3Level and buildLogMessageFromData are instance methods that are effectively called statically, and for some reason the calls to $this are triggering serialization issues with php artisan route:cache. There may be another underlying problem, but a short-term solution is to just make these two methods static.

Other than being a little mismatched code-style-wise, this should be a very safe refactor for the short term.

[amaelftah]

maybe we can just add a check if the app running in console then we donot register web routes at all

private function registerRoutes(): void
    {
        if ($this->app->runningInConsole()) {
            return;
        }
    }

[ashleyhindle]

Thanks for raising @inxilpro 💪 I like the 'runningInConsole' approach too, does that work on your side?

[pushpak1300]

+1 for runningInConsole approach.

[inxilpro]

Excluding it when running in console would mean that if you cached routes locally for some reason, that route wouldn’t be available…

[inxilpro]

I also just tested and confirmed that checking routesAreCached is not enough to solve the problem, although that check probably should be added as well for performance reasons.

[inxilpro]

Another approach would be to introduce a BrowserLogsController instead of using a closure. That would address this issue and arguably be slightly more performant with route caching, since we wouldn't be dealing with a serialized closure. (The performance benefit is negligible, but sometimes it's nice to eek out micro-optimizations when you're writing package code.)

[NickSdot]

I also just tested and confirmed that checking routesAreCached is not enough to solve the problem, although that check probably should be added as well for performance reasons.

I deleted that comment because it of course wouldn't solve the issue when running route:cache; I was a bit too fast with my comment. 🥶

[calebdw]

Can we get this merged? Our CI is broken until this is fixed...

[ashleyhindle]

Let's merge the static fix, then I'll look at a better one - thanks for your insights on this @inxilpro 💪