-
Notifications
You must be signed in to change notification settings - Fork 105
fix: detect if project uses sail #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
822fe74
to
afec83a
Compare
I feel like we also need to update some other stubs or generated guidelines. Ex. The guidelines being generated within CLAUDE.md - these examples would fail without appending "sail" in front
|
Sure, but that's a slightly separate concern. The main thing is getting the mcp server to be utilized in the first place |
+1 - surprised this wasn't picked up during dev. Thanks for the PR. Might be best to allow an override in the user's .env - some projects will have sail installed but unused. |
Can we also add Sail support for the guidelines files in this PR?
Example: === tests rules ===
## Test Enforcement
- Every change must be programmatically tested. Write a new test or update an existing test, then run the affected tests to make sure they pass.
- Run the minimum number of tests needed to ensure code quality and speed. Use `php artisan test` with a specific filename or filter.
</laravel-boost-guidelines> Instead of: |
I think Sail docs can be split out into another PR, but would it not be better to instruct the agent to just use |
Agreed, then it could just be a variable, either |
afec83a
to
742447d
Compare
Hello!
This detects if the project uses
sail
and automatically updates the mcp commandsThanks!