BUG: groupby.idxmin/idxmax with all NA values should raise #62026
+80
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Groupby
API - Consistency
mroeschke
reviewed
Aug 2, 2025
jbrockmendel
reviewed
Aug 3, 2025
doc/source/whatsnew/v3.0.0.rst
Outdated
| @@ -504,7 +504,7 @@ Renamed the following offset aliases (:issue:`57986`): | |||
|
|
|||
| Other Removals | |||
| ^^^^^^^^^^^^^^ | |||
| - :class:`.DataFrameGroupBy.idxmin`, :class:`.DataFrameGroupBy.idxmax`, :class:`.SeriesGroupBy.idxmin`, and :class:`.SeriesGroupBy.idxmax` will now raise a ``ValueError`` when used with ``skipna=False`` and an NA value is encountered (:issue:`10694`) | |||
| - :class:`.DataFrameGroupBy.idxmin`, :class:`.DataFrameGroupBy.idxmax`, :class:`.SeriesGroupBy.idxmin`, and :class:`.SeriesGroupBy.idxmax` will now raise a ``ValueError`` when a group has all NA values, or when used with ``skipna=False`` and any NA value is encountered (:issue:`10694`) | |||
There was a problem hiding this comment.
does 10694 cover both of these cases?
There was a problem hiding this comment.
No - added the linked issue in the OP. Thanks!
jbrockmendel
reviewed
Aug 4, 2025
| @@ -283,8 +283,6 @@ def test_idxmin_idxmax_extremes_skipna(skipna, how, float_numpy_dtype): | |||
| np.nan, | |||
| max_value, | |||
| np.nan, | |||
| np.nan, | |||
| np.nan, | |||
There was a problem hiding this comment.
this change is bc there's an all-NA group so itll now raise?
There was a problem hiding this comment.
Yes, and the case of testing for raising is done elsewhere.
|
Couple of small questions, assuming no surprises on those: LGTM |
…groupby_idxmin_all_na
mroeschke
approved these changes
Aug 5, 2025
|
Thanks @rhshadrach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.