BUG: Fix all-NaT when ArrowEA.astype to categorical #62055
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurlw
changed the title
arthurlw
changed the title
jbrockmendel
reviewed
Aug 6, 2025
pandas/core/arrays/base.py
Outdated
| dtype = pandas_dtype(dtype) | ||
| if dtype == self.dtype: | ||
| if not copy: | ||
| return self | ||
| else: | ||
| return self.copy() | ||
|
|
||
| if isinstance(dtype, CategoricalDtype): |
There was a problem hiding this comment.
Pretty weird to do this in the base class. Can you track down where the actual problem is? Could be hiding other bugs eg in categorical.fromsequence
There was a problem hiding this comment.
Ah okay i'll investigate further
jbrockmendel
reviewed
Aug 6, 2025
| if is_datetime64_any_dtype(cat_dtype) or is_timedelta64_dtype( | ||
| cat_dtype | ||
| ): | ||
| values = values.to_numpy() |
There was a problem hiding this comment.
this can be expensive, particularly in dt64tz. have you figured out why the problem is happening? i.e. if you step through the code, where does the first wrong result show up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type annotations to new arguments/methods/functions.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.