API: make construct_array_type non-classmethod #62060
Merged
+25
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 6, 2025
mroeschke
reviewed
Aug 6, 2025
| @@ -150,7 +150,7 @@ def _coerce_to_data_and_mask( | |||
| if dtype is not None: | |||
| dtype = dtype_cls._standardize_dtype(dtype) | |||
|
|
|||
| cls = dtype_cls.construct_array_type() | |||
| cls = dtype_cls().construct_array_type() | |||
There was a problem hiding this comment.
Nit: Is it possible to change _coerce_to_data_and_mask to pass an dtype instance here?
There was a problem hiding this comment.
thats slightly more invasive since it means updating the annotations etc
There was a problem hiding this comment.
OK good for a follow up then. Would like to avoid always assuming here that it's safe to instantiate these types with no arguments
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
approved these changes
Aug 6, 2025
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Makes the method robust to the possibility of keywords (e.g. na_value, storage) that determine what EA subclass you get. StringDtype already does this.