Skip to content

GH-137484: Have Tools/wasm/wasi use the build triple instead of "build" #137485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Aug 6, 2025

This should help prevent issues where something like a container is used to do one build and then someone tries to build again locally.

…of "build"

This should help prevent issuse where something like a container is used to do one build and then someone tries to build again locally.
@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit f71b4d0 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137485%2Fmerge

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32-wasi PR
  • wasm32 WASI 8Core PR

@brettcannon brettcannon self-assigned this Aug 6, 2025
@brettcannon brettcannon merged commit 0953200 into python:main Aug 6, 2025
44 checks passed
@brettcannon brettcannon deleted the 137484-build-triple-over-build branch August 6, 2025 19:28
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@brettcannon
Copy link
Member Author

It looks like miss-islington had a glitch and didn't leave a comment on the backport PR: #137487

@serhiy-storchaka
Copy link
Member

Reminder about backporting. @brettcannon

@brettcannon
Copy link
Member Author

Reminder about backporting. @brettcannon

I have a backport ready to go, but I'm waiting on 3.14 to be unfrozen for general fixes.

@bedevere-app
Copy link

bedevere-app bot commented Aug 15, 2025

GH-137487 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build OS-wasi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants