Update fork #1
Merged
Update fork #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire question list now lives in the web version of the repo as it is maintained from a single JSON source file, rather than markdown.
We're using npm as our package manager
The previous icon would result in misalignment in the company section
As per this thread: facebook/create-react-app#8499, upgrading to 3.4.0 and rebuilding node_modules helped fix the error.
On the "Question List" tab, the content will "jump" a few pixels to the left due to the content exceeding the page height (ie. it has a lot of rows, which our table does). As a result, we need to account for this by calculating the left and right margin when the user switches to the respective tab, whether the scroll bar is present or not. See https://stackoverflow.com/questions/9341465/prevent-a-centered-layout-from-shifting-its-position-when-scrollbar-appears#answer-42987298
This will prevent width-overflow for the "Question List" tab
This will display the last time the company list was updated
* Added Trie Category Questions * Updated Companies | Trie Category * Updated LC premium questions | Trie
When the page is loaded, the data set will now be sorted automatically according to difficulty then pattern, irregardless of the order that questions are added to /src/data/index.js.
This only applies to the pattern column whereas we leave the difficulty dropdown list untouched.
* Add lock icon to signify leetcode premium questions Fixes #11 * Add `Premium` field to each question This new field will represent whether or not a question requires leetcode premium to view, and also allow users to filter by all, premium, or free questions. * Move Premium to its own column
Referred to https://css-tricks.com/position-sticky-and-table-headers/ for help. Fixes #18
The `Difficulty` filter is now hard-coded, as to avoid running into edge cases using preFilteredRows/filteredRows (see https://github.com/tannerlinsley/react-table/blob/master/docs/api/useFilters.md#column-properties). All filters have been refactored out to a seperate file (filters.js), to reduce code clutter in the Table component. The question list is now sorted by difficulty by default when being exported from src/data/index.js. Fixes #13
* Allow multiple patterns per question Fixes #10 * Convert pattern field to array This update will allow multiple patterns to be added per question. * Update Pattern column cell render to support multiple patterns
This pattern is now renamed to "Heap" with other applicable patterns.
* Hide patterns by default Fixes #25 * Remove useRef import
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Follow-up to #31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.