[blazor] diagnostics - feedback for code.function.name #62836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the telemetry tag name for component method names from the ASP.NET Core-specific aspnetcore.components.method to the OpenTelemetry semantic convention code.function.name, addressing feedback from the OTEL semantic conventions review.
- Updates telemetry tag names to align with OpenTelemetry semantic conventions
- Maintains the same telemetry data collection but with standardized tag naming
- Updates both production code and corresponding test assertions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Components/Components/src/ComponentsMetrics.cs | Updates tag name in metrics collection for event duration and error tracking |
| src/Components/Components/src/ComponentsActivitySource.cs | Updates tag name in activity source for event handling |
| src/Components/Components/test/ComponentsMetricsTest.cs | Updates test assertions to expect the new tag name |
| src/Components/Components/test/ComponentsActivitySourceTest.cs | Updates test assertion to expect the new tag name |
3 tasks
ilonatommy
approved these changes
Jul 21, 2025
|
/ba-g CI infra failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes feedback from OTEL semantic
open-telemetry/semantic-conventions#2235 (comment)